Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Placeholder Overlap in TextField When Selecting Available Adapter on First Render #13468

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

PR4NJ41
Copy link
Contributor

@PR4NJ41 PR4NJ41 commented Feb 4, 2025

Notes for Reviewers

  • This PR enhances the user experience of the TextField component by addressing an issue where the initial value prevented the placeholder animation from displaying correctly.
  • Previously, the placeholder text overlapped with the selected Available Adapter value when it was chosen through the dropdown selector on the first render of the page.

Signed commits

  • Yes, I signed my commits.

Screenshots

Before

Before.mp4

After

After.mp4

Signed-off-by: Pranjal Rajput <pranjal.rajput.che21@itbhu.ac.in>
@github-actions github-actions bot added the component/ui User Interface label Feb 4, 2025
@PR4NJ41 PR4NJ41 temporarily deployed to staging-playground February 4, 2025 16:48 — with GitHub Actions Inactive
@miacycle
Copy link
Contributor

miacycle commented Feb 4, 2025

@augustmood, I wonder if you have feedback on this PR...

@miacycle miacycle requested a review from augustmood February 4, 2025 19:17
Copy link
Contributor

@augustmood augustmood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@amitamrutiya
Copy link
Contributor

Thanks @PR4NJ41 for fixing this issue.

@amitamrutiya amitamrutiya merged commit 021b76a into meshery:master Feb 5, 2025
8 of 9 checks passed
Copy link

github-actions bot commented Feb 5, 2025

END-TO-END TESTS

  • Testing started at: February 5th 2025, 4:12:48 pm

📦 Test Result Summary

  • ✅ 25 passed
  • ❌ 2 failed
  • ⚠️ 10 flaked
  • ⏩ 0 skipped

Duration: 7 minutes and 51 seconds

Overall Result: 👎 Some tests failed.

[Show/Hide] Test Result Details
Test Browser Test Case Tags Result
1 chromium-meshery-provider Transition to disconnected state and then back to connected state unstable ⚠️
2 chromium-meshery-provider Transition to ignored state and then back to connected state unstable ⚠️
3 chromium-meshery-provider Transition to not found state and then back to connected state unstable ⚠️
4 chromium-meshery-provider Delete Kubernetes cluster connections unstable ⚠️
5 chromium-meshery-provider Compare test of a performance profile with load generator "fortio" and service mesh "None" unstable ⚠️
6 chromium-meshery-provider Delete a performance profile with load generator "fortio" and service mesh "None" unstable ⚠️
7 chromium-local-provider Add a cluster connection by uploading kubeconfig file unstable ⚠️
8 chromium-local-provider Transition to disconnected state and then back to connected state unstable ⚠️
9 chromium-local-provider Transition to ignored state and then back to connected state unstable ⚠️
10 chromium-local-provider Transition to not found state and then back to connected state unstable ⚠️
11 chromium-local-provider Delete Kubernetes cluster connections unstable ⚠️
12 chromium-local-provider View detailed result of a performance profile (Graph Visualiser) with load generator "fortio" and service mesh "None" unstable ⚠️
13 chromium-local-provider Edit the configuration of a performance profile with load generator "fortio" and service mesh "None" unstable ⚠️
14 chromium-local-provider Compare test of a performance profile with load generator "fortio" and service mesh "None" unstable ⚠️
15 chromium-local-provider Delete a performance profile with load generator "fortio" and service mesh "None" unstable ⚠️
16 chromium-local-provider Aggregation Charts are displayed
17 chromium-local-provider Connect to Meshery Istio Adapter and configure it
18 chromium-local-provider Toggle "Send Anonymous Usage Statistics" unstable ⚠️
19 chromium-local-provider Toggle "Send Anonymous Performance Results" unstable ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants