Added counts to meshmodel categories #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abdullah1308 <abdullahrafi.1308@gmail.com>
Signed-off-by: abdullah1308 <abdullahrafi.1308@gmail.com>
1 task
leecalcote
requested changes
Jun 24, 2023
| @@ -73,7 +73,7 @@ func GetMeshModelRelationship(db *database.Handler, f RelationshipFilter) (r []R | |||
| if f.Greedy { | |||
| finder = finder.Where("relationship_definition_dbs.kind LIKE ?", "%"+f.Kind+"%") | |||
| } else { | |||
| finder = finder.Where("relationship_definition_dbs.kind = ?", "%"+f.Kind+"%") | |||
There was a problem hiding this comment.
@abdullah1308 the need for this non-greedy change is not clear to me.
There was a problem hiding this comment.
@leecalcote Line 74 is for when we want the search to be greedy. Line 76 is for when we want the search to not be greedy.
When using = ?, using "%"+f.Kind+"%" doesn't work since it searches for the string literal %Kind% which is wrong as we want it to search for Kind.
There was a problem hiding this comment.
leecalcote
approved these changes
Jun 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #
Notes for Reviewers
Signed commits