Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MesheryAnnotationPrefix value #545

Closed

Conversation

akshansh-modi
Copy link

@akshansh-modi akshansh-modi commented Jul 30, 2024

Description

This PR fixes #472

This PR updates the MesheryAnnotationPrefix value from design.meshmodel.io to id.design.meshery.io
Notes for Reviewers
1)All test cases are passing.
2)As mentioned by @leecalcote, we still need to check if we can deploy a design and if the "Open in Visualizer" link works. Can a maintainer assist with this?
Signed commits

  • Yes, I signed my commits.

Signed-off-by: Akshansh <Akshanshmodi2002@gmail.com>
Copy link

welcome bot commented Jul 30, 2024

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

Copy link

stale bot commented Sep 14, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Sep 14, 2024
@leecalcote leecalcote requested a review from Jougan-0 September 17, 2024 05:09
@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Sep 17, 2024
@leecalcote
Copy link
Member

@akshansh-modi Thanks for this. 😃

@hamza-mohd
Copy link
Contributor

Merge conflict...

Copy link

stale bot commented Nov 23, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Nov 23, 2024
Copy link

stale bot commented Dec 7, 2024

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/stale Issue has not had any activity for an extended period of time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename design.meshmodel.io to id.design.meshery.io.
3 participants