-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix release tag function to work with alphanumeric tags w/signoff #557
Conversation
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
…into fixReleaseError
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
@Jougan-0 where did we land on this approach? |
I was working solely on the migration and fixing bugs of the v1beta1 pr now that's done I'll head to this issue. |
@Jougan-0 thank you. I'll put the k6 model to use immediately, when this is completed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was a decision arrived at in terms of when to incorporate consideration of release date vs. tag numbering?
Signed-off-by: Mohd Hamza <135669921+hamza-mohd@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eliminated merge conflicts.
Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
Nope haven't given it a thought again, this needs a revisit later this week if we don't stuck on Kanvas. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue. |
Description
The old function only works for numeric values and sort them. This function sorts tags based on release time rather than tag number.
Notes for Reviewers
Signed commits