utility function to get latest Version w/signoff #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
1 task
lekaf974
approved these changes
Oct 1, 2024
lekaf974
reviewed
Oct 1, 2024
| } | ||
|
|
||
| // Function to get all version directories sorted in descending order | ||
| func GetAllVersionDirsSortedDesc(modelVersionsDirPath string) ([]string, error) { |
There was a problem hiding this comment.
Should we consider to add unit test on this method ?
MUzairS15
suggested changes
Oct 1, 2024
| return nil, fmt.Errorf("no valid version directories found in '%s'", modelVersionsDirPath) | ||
| } | ||
|
|
||
| sort.Slice(versions, func(i, j int) bool { |
There was a problem hiding this comment.
Extract the logic and "Less" function implementation as under sorted semver version / similar.
|
We're in need of fixing the lint check errors. |
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #
Notes for Reviewers
Signed commits