Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add detekt Android CI workflow, migrate to ktlint plugin #1122

Merged
merged 8 commits into from
Jul 3, 2024
Merged

feat: add detekt Android CI workflow, migrate to ktlint plugin #1122

merged 8 commits into from
Jul 3, 2024

Commits on Jul 2, 2024

  1. Add detekt and ktlint checks to Android CI workflow.

    @jamesarich
    jamesarich committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    3b866b8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into github-actions-detekt-ktlint

    @jamesarich
    jamesarich authored Jul 2, 2024
    Configuration menu
    Copy the full SHA
    b22c6cf View commit details
    Browse the repository at this point in the history

  3. Fix: Resolve detekt and ktlint issues 

    This commit resolves various detekt and ktlint issues in the codebase, including:

- Adjusting
 function and property naming conventions
- Addressing long parameter lists and method complexities
- Removing magic numbers and unused parameters
- Fixing new line and max line length issues
- Updating detekt and ktlint configurations in the CI workflow
    @jamesarich
    jamesarich committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    9d5e7ad View commit details
    Browse the repository at this point in the history

  4. Add detekt and ktlint to CI 

    This commit adds detekt and ktlint to the CI pipeline to ensure code quality and consistency.

The new jobs run on Ubuntu and perform the following steps:

- Checkout the code
- Validate the Gradle wrapper
- Mock necessary files for CI
- Set up JDK 17
- Setup Gradle
- Run detekt or ktlint checks
- Upload build reports as artifacts
    @jamesarich
    jamesarich committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    e7c7e9d View commit details
    Browse the repository at this point in the history

  5. Remove detekt, move ktlint to PR checks 

    This commit removes the detekt check from the CI workflow and moves the ktlint check to the
 pull request workflow.
This change streamlines the CI process and ensures that code style is checked before merging.
    @jamesarich
    jamesarich committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    df6b488 View commit details
    Browse the repository at this point in the history

  6. Fix: Rename build reports artifacts 

    Renamed build reports artifacts to detekt-reports and ktlint-reports for clarity.
    @jamesarich
    jamesarich committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    72d7837 View commit details
    Browse the repository at this point in the history

  7. feat: Configure Detekt and Ktlint 

    Configure Detekt and Ktlint with baseline files and move the Detekt configuration to the root level.
    @jamesarich
    jamesarich committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    1a8a594 View commit details
    Browse the repository at this point in the history

  8. Refactor: Migrate ktlint to detekt formatting plugin 

    This commit migrates ktlint functionality to the detekt formatting plugin.

The ktlint Gradle plugin and related configurations have been removed. Instead, the detekt formatting plugin is now used to enforce code style and formatting.

This change simplifies the project's linting setup and consolidates code style enforcement under detekt.
    @jamesarich
    jamesarich committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    cd6e0da View commit details
    Browse the repository at this point in the history