Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel scan select #1141

Merged
merged 7 commits into from
Jul 28, 2024
Merged

Conversation

Robert-0410
Copy link
Contributor

I believe this is related to #953.

Implemented a new dialog that is prompted when the user scans a correct QR code. The dialog provides additional
actions they can perform such as:

  • Cancel: maintains the users current channels.
  • Replace: makes the scanned channels the new user channels. (What would happen before)
  • Save: appends the selected channels to the users existing channels.

Notes

  • The save button will only be enabled if the sum of the current and selected channels is <= max channels.
  • The user can delete channels to make space, if cancel is pressed we maintain the same channels we had before the scan.

Screenshot_20240714-164454_Meshtastic

@andrekir andrekir linked an issue Jul 21, 2024 that may be closed by this pull request
@andrekir
Copy link
Member

needs a few small changes but nice work!

regarding the buttons:

Replace: makes the scanned channels the new user channels. (What would happen before)

convention is the default action ("positive") is placed on the right side of the dialog.

Save: appends the selected channels to the users existing channels.

ensure the dialog buttons provide clear feedback of what they do: "Save" should read "Add".

Copy link
Member

@andrekir andrekir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done, thanks!

@Robert-0410
Copy link
Contributor Author

Thank you!!

@andrekir andrekir merged commit ed17ae0 into meshtastic:master Jul 28, 2024
5 checks passed
@Robert-0410 Robert-0410 deleted the Channel_Scan_Select branch August 27, 2024 02:15
danwelch3 pushed a commit to danwelch3/meshtastic-android that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Honor add=true query string value when scanning QR codes
2 participants