Adds support for known 0 hopsAway #1295
Open
+30
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the database schema to allow storing null values for the 'hopsAway' field in the 'nodes' table. This allows for better representation of unknown hop counts instead of defaulting to 0. The UI is also updated to display signal information and node details accordingly when 'hopsAway' is null.
ianmcorvidae
reviewed
Oct 8, 2024
There was a problem hiding this comment.
I'm assuming the DB stuff is right since I'm not really up on that part. I think there's an update needed in MeshService that I've outlined, plus making sure the wantconfig NodeInfo get initialized properly, and the display needed is slightly different than this
This commit addresses two issues: - **Signal Info Display**: The signal info display is enhanced to show channel information, RSSI, SNR, and hops away in a clearer and more organized way using separators. It also handles cases where hopsAway is null or 0. - **Node Hop Calculation**: This now explicitly checks if hopsAway is present in the proto message before using it. These changes improve the usability and accuracy of signal information for users.
ianmcorvidae
approved these changes
Oct 9, 2024
This replaces previous omitted logic in signalInfo to only display snr and rssi when the signal is poor. - RSSI and SNR are now only displayed for local nodes (hopsAway = 0) when the signal quality is poor (SNR < 100 and RSSI < 0). - This prevents unnecessary clutter in the UI for nodes with good signal strength or those that are further away.
- Revert whitespace changes - Simplify `hopsAway` assignment using `if` expression.
- Revert whitespace changes
Changes the constants used for RSSI and SNR to `MAX_VALID_RSSI` and `MAX _VALID_SNR` to better reflect their purpose. This makes it clearer that these values represent the maximum valid values for these metrics.
andrekir
requested changes
Oct 9, 2024
This reverts commit f7dccda.
Since NodeInfo.hopsAway is nonNullable, set it to zero when converting from NodeEntity.
andrekir
approved these changes
Oct 9, 2024
Updates the code to handle the new default value and display "unknown" when the value is -1. Reverts database changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the database schema to allow storing null values for the 'hopsAway' field in the 'nodes' table.
This allows for better representation of unknown hop counts instead of defaulting to 0.
The UI is also updated to display signal information and node details accordingly when 'hopsAway' is null and zero.