Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add feedback for configuration changes #748

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

andrekir
Copy link
Member

@andrekir andrekir commented Oct 3, 2023

Previously, UI feedback was limited to fetching configuration (getters). This PR adds feedback for configuration changes (setters).

  • Loading: adds progress bar for each received delivery confirmation
    • asynchronous tracking of multiple admin packet request IDs
    • auto-update total based on number of requests
  • Error: show message errors occurs
  • Success: show a success message when all requests are delivered without errors

@andrekir andrekir merged commit 7c30d86 into master Oct 3, 2023
1 check passed
@andrekir andrekir deleted the config_setters branch October 3, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant