Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mesh.options and mesh.proto are symlinks #2

Closed
EntropyWorks opened this issue Feb 27, 2020 · 1 comment
Closed

mesh.options and mesh.proto are symlinks #2

EntropyWorks opened this issue Feb 27, 2020 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@EntropyWorks
Copy link

EntropyWorks commented Feb 27, 2020

Just looking around I see two files that are symlinks outside the repo.

mesh.options -> ../MeshUtil/app/src/main/proto/mesh.options
mesh.proto -> ../MeshUtil/app/src/main/proto/mesh.proto

Are these important for the build?

@geeksville
Copy link
Member

geeksville commented Feb 27, 2020

They aren't exactly required for the build because the bin/regen-protos.sh script uses the nanopb tool to generate C code from them (and that C code is checked in). They are actually currently located in the sister android app: https://github.com/geeksville/Meshtastic-Android.

If you'd like to rebuild the C code from the .proto just clone that android repo as a peer directory to the esp32 project. Thanks for the note though - this whole relationship needs to be cleaned up, mostly I wasn't wanting to have to deal with git submodules yet. ;-)

I'll leave this bug open as a reminder to clean this up.

@geeksville geeksville added this to the BeforeBeta milestone Feb 28, 2020
@geeksville geeksville added bug Something isn't working good first issue Good for newcomers labels Feb 28, 2020
geeksville pushed a commit that referenced this issue May 19, 2020
mc-hamster added a commit that referenced this issue Sep 17, 2020
geeksville pushed a commit that referenced this issue Oct 29, 2020
mc-hamster pushed a commit that referenced this issue Jan 5, 2022
@GUVWAF GUVWAF mentioned this issue Apr 20, 2023
thebentern added a commit that referenced this issue Jun 27, 2023
* Default ext. notification output for RAK to LED #2

* Enabled by default

* Update

* Wrong macro

* Output and nag
jp-bennett added a commit that referenced this issue Sep 28, 2023
thebentern added a commit that referenced this issue Nov 5, 2023
* INA3221 / Power Telemetry Variant Implementation
	modified:   platformio.ini
	modified:   src/configuration.h
	modified:   src/detect/ScanI2C.h
	modified:   src/detect/ScanI2CTwoWire.cpp
	modified:   src/main.cpp
	modified:   src/modules/Modules.cpp
	new file:   src/modules/Telemetry/PowerTelemetry.cpp
	new file:   src/modules/Telemetry/PowerTelemetry.h
	new file:   src/modules/Telemetry/Sensor/INA3221Sensor.cpp
	new file:   src/modules/Telemetry/Sensor/INA3221Sensor.h
	modified:   src/mqtt/MQTT.cpp

* ifdef for portduino / linux native
	modified:   src/modules/Telemetry/PowerTelemetry.cpp

* try #2
	modified:   src/modules/Modules.cpp
	modified:   src/modules/Telemetry/PowerTelemetry.cpp
	deleted:    variants/xiao_ble/1.0.0/libraries/SPI/SPI.cpp

* try #3
	modified:   src/modules/Modules.cpp

* try #4
	modified:   src/modules/Telemetry/PowerTelemetry.cpp

* try #5?
	modified:   src/modules/Telemetry/PowerTelemetry.cpp

* try #6
	modified:   src/modules/Telemetry/PowerTelemetry.cpp

---------

Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
thebentern pushed a commit that referenced this issue Nov 20, 2023
* INA3221 bugfixes & refinement
Reorganized and refactored some INA3221 code
Added comments
Added missing shunt resistor value (100mΩ)
Added INA3221 Channel 1 to getINAVoltage() for device battery monitoring
	modified:   src/Power.cpp
	modified:   src/modules/Telemetry/PowerTelemetry.cpp
	modified:   src/modules/Telemetry/Sensor/INA3221Sensor.cpp
	modified:   src/modules/Telemetry/Sensor/INA3221Sensor.h
	modified:   src/power.h

* reset-nodedb retain device nodeinfo
	modified:   src/mesh/NodeDB.cpp

* reset-nodedb #2
	modified:   src/mesh/NodeDB.cpp

---------

Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>
jp-bennett pushed a commit that referenced this issue Mar 6, 2024
jp-bennett added a commit that referenced this issue May 31, 2024
thebentern pushed a commit that referenced this issue May 31, 2024
…e offset (#3999)

* Run tzset() and localtime() in getTZOffset() to ensure proper timezone offset

* Try #2 to fix timezone/DST
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants