-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broadcast neighbor info #2535
Broadcast neighbor info #2535
Conversation
also update trunk
🤖 Pull request artifacts
|
This is not yet working correctly; now it regards everyone from whom it received a packet as neighbor. The |
Logic seems okay now. (Node 0 has NodeNum 16, Node 1 has 17, Node 2 has 18). Still needs some more work, e.g. handling the AdminMessages for configuring the module and sending only the @ajmcquilkin There is a |
@GUVWAF I think 2x the This also makes me wonder whether 2x should be the default for the client, but where the user can override this default duration in the application settings. I'm envisioning an application override being necessary since the user may know that the broadcast interval of the connected node is much slower or faster than most nodes on the network. A random idea would be for nodes to somehow advertise their timeout when they enter the network, but 1) that sounds out of scope of this PR and 2) there still wouldn't be a guarantee that all nodes would receive this advertisement. |
@ajmcquilkin If you want it to be configurable in the client, we can also just not remove any neighbors in the firmware (like it is now, so easiest to implement) except when one does the NodeDB reset. Either way, I think then we still need to store the last Rx time and send this to the client. Then you can decide in the client whether a link should be removed. You could also more easily warn a user not to set it lower than the broadcast interval of any node, because then you might remove it too soon. I know I voted against transmitting the Rx time over the mesh and I think that's also not necessary, but storing it will be needed if you want to remove any links after a certain time. Unfortunately I can't attend the meeting on Thursday, but maybe you can discuss this there. |
Any chance to get this feature in next release? |
This will go into 2.2.x - rebasing |
also update trunk