Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add board and variant definitions for EBYTE_ESP32-S3 #2882

Merged
merged 84 commits into from
Apr 21, 2024

Conversation

S5NC
Copy link
Contributor

@S5NC S5NC commented Oct 10, 2023

Accidentally closed #2841 when renaming the branch and can't reopen. This variant is intended to eventually have support for all 38.5x24mm EBYTE SPI LoRa modules, such as:

  • E22-400M30S
  • E22-400M33S (may need to limit SX1268 output power - further testing required!)
  • E22-900M30S
  • E22-900M33S (must limit SX1262 output power!)
  • E220-400M30S
  • E220-900M30S

It also provides the framework for the use of any SX126x or LLCC68 module, no matter its size (including E22-900M22S, etc.), on the ESP32-S3 with custom configurations due to the variant.h file which is configurable for all hardware implementations, and a pins_arduino.h file which uses values from the variant.h file to configure itself.

@S5NC
Copy link
Contributor Author

S5NC commented Dec 2, 2023

For now I will wait untill someone is able to test other EBYTE modules to verify that 22 dBm output from the radio ID is safe, doesn't damage the radio, and is what results in and was inteded to be used to get the maximum power. For non-E22 models they would need to be tested separately, and they have a different internal LoRa IC power output capability.

@S5NC
Copy link
Contributor Author

S5NC commented Dec 2, 2023

Would also need to add a build job?

@S5NC
Copy link
Contributor Author

S5NC commented Apr 10, 2024

It is guaranteed that boards with the E22-900M33S will be damaged by outputting 22 dBm out of the radio IC. Ideally the SX126x should have an integrated EEPROM which limits the output power settings to a certain maximum, although this is complicated by the fact that multiple parameters affects its output power.

However, I trust that people who replace the module with their own are able to do their proper research, so will now implement support for the 400M series too (of which there is also a 33S model).

@thebentern thebentern marked this pull request as ready for review April 21, 2024 13:40
@thebentern thebentern merged commit 9822a85 into meshtastic:master Apr 21, 2024
70 checks passed
@S5NC S5NC deleted the EBYTE_ESP32-S3 branch September 12, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants