Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes [3074] Heltec Tracker Screen issues + minor fixes #3213

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Fixes [3074] Heltec Tracker Screen issues + minor fixes #3213

merged 4 commits into from
Feb 20, 2024

Conversation

Gabrielerusso
Copy link
Contributor

@Gabrielerusso Gabrielerusso commented Feb 12, 2024

Fixes 3074 and 3187 of heltec tracker, i found other issues such as the I2C pin not specified and the stock 21/22 were used, but pin 22 is not available, now using 45/46. Also the screen dimension and offsets now are correct.

A major difference was to split the two hardware version, to reduce overhead code as all the new boards are V1.1 and to me it made little sense to have such differentiations at runtime. The two hardware version have the same "external" name, just two different binaries.
new env names:

heltec-wireless-tracker-V1_0
heltec-wireless-tracker-V1_1
NOTE: i2c pin fix was never tried, original i2c pin are reported as 41/42 but that was false as those are used for the TFT SPI.

This is related to PR 3163, i'm just dividing that in multiple PR for easier management

@Gabrielerusso Gabrielerusso changed the title Fix Heltec Tracker Screen issues Fixes [3074] Heltec Tracker Screen issues + minor fixes Feb 12, 2024
@geeksville
Copy link
Member

This pull request has been mentioned on Meshtastic. There might be relevant details there:

https://meshtastic.discourse.group/t/new-heltec-wireless-tracker-product/7787/14

@thebentern
Copy link
Contributor

@Gabrielerusso FYI, we had to revert the HW_MODEL name change of HELTEC_WIRELESS_TRACKER_V1_1 back to HELTEC_WIRELESS_TRACKER because it was a breaking change for the Android platform.

@thebentern thebentern changed the base branch from master to heltec-tracker February 18, 2024 13:20
@thebentern thebentern changed the base branch from heltec-tracker to master February 18, 2024 13:31
@thebentern
Copy link
Contributor

@Gabrielerusso if you can fix the merge conflicts, I'll just go ahead and merge and fix the variant.

@Gabrielerusso
Copy link
Contributor Author

@Gabrielerusso if you can fix the merge conflicts, I'll just go ahead and merge and fix the variant.

i'm sorry, due to imminent exams i'm too busy rigth now.

Fix Heltec Tracker Screen issues like wrong offsets, display size and screen not shutting down.

Divides board into two different envs for 1.0 and 1.1 version PCB
@Gabrielerusso
Copy link
Contributor Author

@Gabrielerusso if you can fix the merge conflicts, I'll just go ahead and merge and fix the variant.

should be all ok, i'll try to compile and flash it rigth now and see if everything is working.

rename varian of heltec tracker 1.1 to "heltec tracker" to be retro-compatible.

Trunk formatting.
Heltec Tracker increase Screen update to 3Hz from 1Hz
@thebentern thebentern merged commit 0bfac7b into meshtastic:master Feb 20, 2024
66 checks passed
jimwhitelaw pushed a commit to jimwhitelaw/aotromesh that referenced this pull request Feb 22, 2024
)

* Fix Heltec Tracker Screen issues

Fix Heltec Tracker Screen issues like wrong offsets, display size and screen not shutting down.

Divides board into two different envs for 1.0 and 1.1 version PCB

* Helteck wireless tracker default version V1_1

* rename heltec tracker 1.1 - trunk fmt

rename varian of heltec tracker 1.1 to "heltec tracker" to be retro-compatible.

Trunk formatting.

* Heltec Tracker increase Screen update to 3Hz

Heltec Tracker increase Screen update to 3Hz from 1Hz
jimwhitelaw pushed a commit to jimwhitelaw/aotromesh that referenced this pull request Feb 28, 2024
)

* Fix Heltec Tracker Screen issues

Fix Heltec Tracker Screen issues like wrong offsets, display size and screen not shutting down.

Divides board into two different envs for 1.0 and 1.1 version PCB

* Helteck wireless tracker default version V1_1

* rename heltec tracker 1.1 - trunk fmt

rename varian of heltec tracker 1.1 to "heltec tracker" to be retro-compatible.

Trunk formatting.

* Heltec Tracker increase Screen update to 3Hz

Heltec Tracker increase Screen update to 3Hz from 1Hz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heltec Tracker Screen Timeout[Bug]:
4 participants