Fixes [#3172] possible position leak when location is disabled

[Gabrielerusso]

Related to #3172 fixes location leaks when location is disabled and we don't want our position to be given.
basically we send our position only if the location is enabled, and if it get disabled we reset the local data to avoid any unwanted data sharing.

This is also part of PR #3163

[garthvh]

This changes the meaning of a bunch of settings, there is no leak, someone sent a position to the node.

[Gabrielerusso]

This changes the meaning of a bunch of settings.

What does change? Everything works the same as before, just when the gps is manually disabled no more data is streamed. If a fixed position is set then nothing changes.

location enabled or fixed position enabled -> send location
location disabled and fixed position disabled -> don't send anything

[Gabrielerusso]

there is no leak, someone sent a position to the node

The local node position is never deleted when location is disabled, unless you restart the board after disabling the location it will keep that.

[garthvh]

there is no leak, someone sent a position to the node

The local node position is never deleted when location is disabled, unless you restart the board after disabling the location it will keep that.

There is no disable location setting, that turns off the hardware GPS.

[Gabrielerusso]

there is no leak, someone sent a position to the node

The local node position is never deleted when location is disabled, unless you restart the board after disabling the location it will keep that.

There is no disable location setting, that turns off the hardware GPS.

It's called "meshtastic_Config_PositionConfig_GpsMode_DISABLED" this does enable or disable location (position). GPS was just used to refer for the location, doesn't actually exist a disable option for every single GNSS.

[garthvh]

there is no leak, someone sent a position to the node

The local node position is never deleted when location is disabled, unless you restart the board after disabling the location it will keep that.

There is no disable location setting, that turns off the hardware GPS.

It's called "meshtastic_Config_PositionConfig_GpsMode_DISABLED" this does enable or disable location (position). GPS was just used to refer for the location, doesn't actually exist a disable option for every single GNSS.

It turns off the GPS module itself, you can still get positions from the phone, or broadcast the position already stored in the nodedb. There is no "I sent a position to the device but I don't ever want it to be used" option currently, if we have a position it gets used. It only gets broadcast over the mesh if you have fixed position on.

[thebentern]

Yes, GPS != Position module is where the confusion comes from

[Gabrielerusso]

there is no leak, someone sent a position to the node

The local node position is never deleted when location is disabled, unless you restart the board after disabling the location it will keep that.

There is no disable location setting, that turns off the hardware GPS.

It's called "meshtastic_Config_PositionConfig_GpsMode_DISABLED" this does enable or disable location (position). GPS was just used to refer for the location, doesn't actually exist a disable option for every single GNSS.

It turns off the GPS module itself, you can still get positions from the phone, or broadcast the position already stored in the nodedb. There is no "I sent a position to the device but I don't ever want it to ever be used" option currently, if we have a position it gets used. It only every gets broadcast over the mesh if you have fixed position on.

If it was a setting to disable one by one every GNSS systems then i would agree that this would change the dynamics, but in our case the "GPS" name is just used to refer to the location, if there is an hardware capable of GLONASS or whatever it's enabled and disabled with the same flag.
I uderstand what do you mean, but i think this is too general to be used in that way, most people call GPS the location services.

[Gabrielerusso]

Yes, GPS != Position module is where the confusion comes from

in that case would make more sense to use two setting, like in car and mobile devices the user enabled/disable location, not the GNSS.

1. location
2. hardware GNSS

[Gabrielerusso]

I think this one is still valid even if the "gpsmode" is used for the hardware GNSS module, as when it's decativated there is no use for the previous data if "fixed position" is disabled.

[garthvh]

I would prefer a clean pull, probably doing this on nodedb reset. @jp-bennett I think this could be related to the preventing a node from deleting itself from the nodedb, should we clear the last position from the current node when we reset the nodedb?

[jp-bennett]

I think this could be related to the preventing a node from deleting itself from the nodedb

Does that change apply when doing a NodeDB reset? A full reset should probably delete the local node's entry, too.

[Gabrielerusso]

Does that change apply when doing a NodeDB reset?

The change i did applies only when GPS::disable() is called.

[Gabrielerusso]

all the changes on this file on the other hand could be omitted until there is a location option.

[jp-bennett]

I'm working on a per-channel GPS setting that might be a better way to do this. It's going to be a setting that explicitly controls the sending of locations.

[Gabrielerusso]

I'm working on a per-channel GPS setting that might be a better way to do this. It's going to be a setting that explicitly controls the sending of locations.

I'm working on a per-channel GPS setting that might be a better way to do this. It's going to be a setting that explicitly controls the sending of locations.

I think it's better to start calling things by their names, otherwise a lot of confusion is generated, by "GPS settings" you mean the general position settings or the hardware GNSS module settings?
If we use "GPS" to refer to the Hardware GNSS module and then we use "GPS" for the location service and then we use GPS for the signle GNSS mode of Hardware GNSS this becomes a nigthmare :D .

In the future multiple options to be activated could be implemented as newer GNSS modules support GPS/Galileo/GLONASS/.., so a more precise definition migh be better.

For the location setting i think that a single option to disable location data from any source would be the best choiche, usable directly from the device like it's done with the triple click now.