fix: device PMU shutdown (part 2) #3596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Pull request artifactsempty string
|
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Apr 11, 2024
thebentern
approved these changes
Apr 12, 2024
mverch67
added a commit
that referenced
this pull request
Apr 13, 2024
thebentern
added a commit
that referenced
this pull request
Apr 14, 2024
* fix: device TFT powersave (part 3) * trunk fmt * trunk fmt * undo bluetooth deinit from #3596 * revert code for heltec tracker --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shutdown for devices with PMU (tbeam, T-Watch) seems broken. E.g. a shutdown tbeam still consumes around 10mA and since #3162 the screen even stays on (showing "Shutdown...") when shutdown.
This PR fixes Power::shutdown() and redirects the PMU shutdown into the deep sleep branch to switch off all uneccesary peripherals before the pmu shutdown.
The tbeam v1.1 deep sleep power consumption (when using the Lilygo 1.3" display) dropped from 10mA to 1mA.