-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: default to fuzzy GPS location on the Default Channel #4467
feature: default to fuzzy GPS location on the Default Channel #4467
Conversation
|
I think this is a reasonable change. @jp-bennett @garthvh any objections? |
Might be good to target 2.5, the circles may not even be in the play store yet. These imprecise positions just seem wrong without the visualization in place. |
I have one thought, which is that Android currently has options for 32 (high precision), 16 (medium precision) and 11 (low precision) only, and shows an input box for other options (but only if it's already outside of those three + disabled). I think we should either use one of those here, or (better, IMO) add more options to the default available ones on Android to include 14. Either adding medium-low at 14 (and medium-high, maybe, but 16 is already kinda that), or adding a way to select everything in something like 10-19 or 11-16 or such (whatever range iOS allows, probably). |
iOS does 10...19 for config and map display and defaults to 13. I have code that displays the estimated distance on a slider. |
And I chose 13 as the default as it would not be precise geolocation data under the California law. |
@mrfyda Let's default to 13 since that has a legal basis, and can we get that option added to the android app?@jamesarich |
Can we make this an issue on the android repo so it doesn't get lost in the shuffle, pls. Not sure when I'll have some more cycles to burn. |
|
I haven't tested the alpha firmware yet, but I have noticed on the iOS app that the fuzzy circles can be very... visually noisy and distracting. I can't imagine how messy the map would appear with everyone having fuzzy circles by default. I'd like to request that the circles only show when a node is tapped on - or at least a way to turn the wider circles off with the options. Thanks! |
The whole point is to see at a glance that it is imprecise without having to click on it, the circles are transparent and can overlap fine. |
First contribution to the repo, attempting to fix #4412.
The original issue suggested using a default fuzzy location with 700m precision. This pull requests instead is using ~1500m precision which is the same default as for MQTT Map Report module.