for #4154 Only enable Vext regulator when needed for either Screen or GPS #4527

geeksville · 2024-08-21T23:57:28Z

(just opening now for CI notifications)

notes to self:

Changes in this PR

change GPS code to use virtual gpio for pwr enable (so that we can manage more cleverly)
change TFT code to use a virtual gpio for backlight enable
cleanup a bunch of redundant variant defs which led to an explosion of unneeded ifdefs
use virt GPIOs inside screen and GPS
confirm that power savings works. Done: with this change when the GPS and screen are both powered down the power consumption is about 10mA lower on the USB 5V in (I haven't yet tested when running on battery, but this matches expected behavior based on the regulator datasheet)
confirmed that if the screen is needed the regulator is powered up as needed.

TODO still

test that GPS still works!

@todd-herbert

* Currently only on heltec tracker, but could use ADC_USE_PULLUP on other boards that could benefit * Thanks @todd-herbert and @StevenCellist for the instructions ;-) * Remove nasty Heltec_wireless #ifdefs that got somehow added to Power.cpp, instead use proper variant defs * Cleanup adc enable/disable code a bit for less copy-paste cruft

No need for _V05 and _V03 definitions - I think there was a slight misunderstanding on how variant files are supposed to _decrease_ #ifdef code in the cpp files.

…ight enable

Therefore don't just randomly be writing to a GPIO numbered -1 Instead just don't try to control the backlight NOTE: I don't have a 'wiphone' to test with, but I saw this via inspection while cleaning up some other stuff.

* Initial support for RadioMaster Bandit. * Different lighting can be made for Button 1 & 2 on the Bandit. Changes to AmbientLighting will turn off af shutdown(). * Trunk * Trunk again.

…opics one nesting level deep (meshtastic#4528)

…c#4542)

But in an attempt to avoid updating lots of files, make it default to LOW

(from src/extra_variants/README.md) This directory tree is designed to solve two problems. - The ESP32 arduino/platformio project doesn't support the nice "if initVariant() is found, call that after init" behavior of the nrf52 builds (they use initVariant() internally). - Over the years a lot of 'board specific' init code has been added to init() in main.cpp. It would be great to have a general/clean mechanism to allow developers to specify board specific/unique code in a clean fashion without mucking in main. So we are borrowing the initVariant() ideas here (by using weak gcc references). You can now define lateInitVariant() if your board needs it. If you'd like a board specific variant to be run, add the variant.cpp file to an appropriately named subdirectory and check for \_VARIANT_boardname in the cpp file (so that your code is only built for your board). You'll need to define \_VARIANT_boardname in your corresponding variant.h file. See existing boards for examples. This approach has no added runtime cost.

…eltec-tracker (saves power)

…htastic#4516) security option. Per discussion in meshtastic#4375 no need to preserve the old options when changing to this new simpler single boolean because they were newish, rarely used and only for 'advanced' developers.

* Create .gitpod.yml * Update .gitpod.yml

devcontainers can be used by IDEs/editors like VS Code to create a standardized development environment in a container

Co-authored-by: thebentern <9000580+thebentern@users.noreply.github.com>

* Add support for Adafruit Feather RP2040 with RFM95. * Update mesh.pb.h dropping this change from the file generated by the protobuf * Update mesh.pb.h remove these reverting changes * Update mesh.pb.h oops, missed a comma

* Mask out random bits when doing queue ordering * Parenthesis

…that may be unset. (meshtastic#4562) Co-authored-by: Ben Meadors <benmmeadors@gmail.com>

* set current time to system time in portduino build * fix includes order --------- Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>

…ings (meshtastic#4573)

…ic#4575)

CLAassistant · 2024-08-28T18:26:39Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
11 out of 12 committers have signed the CLA.

✅ geeksville
✅ thebentern
✅ gjelsoe
✅ jp-bennett
✅ ianmcorvidae
✅ jhollowe
✅ miltieIV2
✅ Nestpebble
✅ caveman99
✅ mrfyda
✅ pccr10001
❌ github-actions[bot]
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

GPSFan · 2024-09-02T13:29:46Z

Please make sure that there is some way to keep the GPS powered all the time. In the past setting GPS Update Interval to <=10 sec would do this. The UC6580 GNSS chip in the Wireless Tracker is very good, there are use cases where power consumption is secondary to position accuracy.

geeksville · 2024-09-02T15:14:03Z

@GPSFan no worries on that aspect. This doesn't change the GPS power up/down stuff at all. If the GPS was previously enabled it will still be enabled after this change. The only change here is: when GPS is disabled (and screen is also disabled) turn off the regulator that powers them (to prevent the 10mA drain from that regulator).

geeksville added 12 commits August 21, 2024 16:53

Remove redundant ST7735_BL variant defs.

7fb9b09

No need for _V05 and _V03 definitions - I think there was a slight misunderstanding on how variant files are supposed to _decrease_ #ifdef code in the cpp files.

Merge the three redundant backlight enables into the single TFT_BL flag

3ae8aad

Remove all sorts of redundant VEXT_ENABLE ifdefs

5ccb6df

Remove unneeded VGNSS_CTRL_V03

2dda640

change GPS to use virtual GPIOs (for meshtastic#4154)

5570b6b

Merge remote-tracking branch 'root/master' into pr-fix4154

02c34e6

For meshtastic#4154 - change TFT driver to use virtual GPIO for backl…

db6e591

…ight enable

Remove redundant defintions of ST7789_BACKLIGHT_EN

2a7cf9d

Don't create backlight instances when the variant hasn't specified a pin

f77c5f6

wiphone isn't setting a valid backlight enable pin

5c5cbb2

Therefore don't just randomly be writing to a GPIO numbered -1 Instead just don't try to control the backlight NOTE: I don't have a 'wiphone' to test with, but I saw this via inspection while cleaning up some other stuff.

Make specifying VEXT_ON_VALUE manatory if using VEXT_ENABLE

e6163a5

geeksville force-pushed the pr-fix4154 branch from 521d37b to e6163a5 Compare August 22, 2024 18:26

geeksville changed the title ~~for #4154 DO NOT MERGE~~ for #4154 Only enable Vext regulator when needed for either Screen or GPS Aug 28, 2024

thebentern and others added 16 commits August 28, 2024 11:25

Save nodedb after favoriting (or removing) (meshtastic#4537)

0617573

Adds has_x bools to position packet. (meshtastic#4540)

710fdbd

Fix copyPasta in NodeDB (meshtastic#4538)

9b2ef97

Initial support for RadioMaster Bandit. (meshtastic#4523)

de41a05

* Initial support for RadioMaster Bandit. * Different lighting can be made for Button 1 & 2 on the Bandit. Changes to AmbientLighting will turn off af shutdown(). * Trunk * Trunk again.

Use the '+' wildcard for MQTT rather than '#', to subscribe only to t…

fe9a80a

…opics one nesting level deep (meshtastic#4528)

Found more places to set explicit has_optional on position (meshtasti…

9de0b7c

…c#4542)

Dum dum zero comparision

b285aa5

Older variant.h files (IMO sloppily) don't define VEXT_ON_VALUE

5ce5b7b

But in an attempt to avoid updating lots of files, make it default to LOW

for meshtastic#4154 use a binary gpio transformer to manage vext on h…

8a9cc72

…eltec-tracker (saves power)

add a .yml to setup a Gitpod instance quickly (meshtastic#4551)

eddb727

* Create .gitpod.yml * Update .gitpod.yml

Add devcontainer (meshtastic#4491)

17b2a83

devcontainers can be used by IDEs/editors like VS Code to create a standardized development environment in a container

[create-pull-request] automated change (meshtastic#4544)

059d558

Co-authored-by: thebentern <9000580+thebentern@users.noreply.github.com>

Userlite mem comparison (meshtastic#4552)

c11a660

Protos

927a35e

miltieIV2 and others added 13 commits August 28, 2024 11:25

Deal with admin_key being repeated (meshtastic#4558)

574124a

Mask out random bits when doing queue ordering (meshtastic#4561)

3c4d964

* Mask out random bits when doing queue ordering * Parenthesis

Don't compare nodeDB macaddr to owner.macaddr, because in rare cases …

e3ce3a3

…that may be unset. (meshtastic#4562) Co-authored-by: Ben Meadors <benmmeadors@gmail.com>

set current time to system time in portduino build (meshtastic#4556)

cc93df2

* set current time to system time in portduino build * fix includes order --------- Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>

Add RAK4631 hex to firmware release

72c82c1

fix meshtastic#4390 (meshtastic#4571)

94c3bb4

Fix devcontainer Dockerfile build

545d32f

Fix super tiny T1114 tft font size and fork repo to fix compiler warn…

3ad0af5

…ings (meshtastic#4573)

trunk upgrade (meshtastic#4574)

ad93179

Fix T1000-E default to turn on buzzer for Ext. Notification (meshtast…

f5633bf

…ic#4575)

Add button secondary and enable scan-select on T190 (meshtastic#4577)

a1bf0d8

fix CI warnings (and change CI comment to be correct)

dc9f6e1

geeksville force-pushed the pr-fix4154 branch from 5f16840 to dc9f6e1 Compare August 28, 2024 18:26

Merge branch 'master' into pr-fix4154

9e20b0e

geeksville marked this pull request as ready for review August 29, 2024 01:12

HarukiToreda mentioned this pull request Aug 29, 2024

Heltec Tracker v1.1 U6 wastes power #4154

Open

Merge branch 'master' into pr-fix4154

8729cdb

thebentern approved these changes Aug 30, 2024

View reviewed changes

caveman99 added 2 commits September 2, 2024 09:16

Merge branch 'master' into pr-fix4154

3bf20dc

Merge branch 'master' into pr-fix4154

367d787

caveman99 merged commit 0588d69 into meshtastic:master Sep 2, 2024
2 of 5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

for #4154 Only enable Vext regulator when needed for either Screen or GPS #4527

for #4154 Only enable Vext regulator when needed for either Screen or GPS #4527

geeksville commented Aug 21, 2024 •

edited

Loading

CLAassistant commented Aug 28, 2024 •

edited

Loading

GPSFan commented Sep 2, 2024

geeksville commented Sep 2, 2024

for #4154 Only enable Vext regulator when needed for either Screen or GPS #4527

for #4154 Only enable Vext regulator when needed for either Screen or GPS #4527

Conversation

geeksville commented Aug 21, 2024 • edited Loading

Changes in this PR

TODO still

CLAassistant commented Aug 28, 2024 • edited Loading

GPSFan commented Sep 2, 2024

geeksville commented Sep 2, 2024

geeksville commented Aug 21, 2024 •

edited

Loading

CLAassistant commented Aug 28, 2024 •

edited

Loading