Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Heltec T1114 hardware model to build #4719

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Add Heltec T1114 hardware model to build #4719

merged 1 commit into from
Sep 16, 2024

Conversation

thebentern
Copy link
Contributor

Closes #4714

@thebentern thebentern merged commit 8d57b61 into master Sep 16, 2024
107 checks passed
@thebentern thebentern deleted the T1114-hwmodel branch September 16, 2024 01:37
@dahanc
Copy link
Contributor

dahanc commented Sep 16, 2024

I think there's a typo... the product model number is T114, not T1114: the change to architecture.h adds a checks for #elif defined(HELTEC_T1114), but platformio.ini adds a -DHELTEC_T114.

@fifieldt
Copy link
Contributor

You're right :(

@fifieldt
Copy link
Contributor

#4728

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fifieldt fifieldt fifieldt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Heltec T114 HW_VENDOR is set to generic nrf52840dk
3 participants
@thebentern @dahanc @fifieldt