Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ublox M10 Setup #4842

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Fix Ublox M10 Setup #4842

merged 1 commit into from
Sep 24, 2024

Conversation

fifieldt
Copy link
Contributor

There is no EXTINT pin available on the Tdeck, which uses the Ublox M10 GPS. Therefore our previous hack to use that pin makes the GPS not work. That workaround was implemented to fix sleep issues which have now since been fixed with the state machine.

This patch restores the state prior to the hack, which is known-working.

Additionaly, it was discovered that M10s hate it when you try and save to non-extistent eeprom/SPI flash.

This patch creates a new SAVE command for the M10 that fixes this issue.

Many thanks to @MisterC925 whose report and testing was essential for this fix.

fixes #4625

There is no EXTINT pin available on the Tdeck, which uses
the Ublox M10 GPS. Therefore our previous hack to use that pin
makes the GPS not work. That workaround was implemented to
fix sleep issues which have now since been fixed with the
state machine.

This patch restores the state prior to the hack, which is
known-working.

Additionaly, it was discovered that M10s hate it when you
try and save to non-extistent eeprom/SPI flash.

This patch creates a new SAVE command for the M10 that fixes
this issue.

Many thanks to @MisterC925 whose report and testing was
essential for this fix.

fixes meshtastic#4625

Co-Authored-By: Ken McGuire <kenm@paonia.com>
@thebentern thebentern merged commit b709d47 into meshtastic:master Sep 24, 2024
107 checks passed
@fifieldt fifieldt deleted the fix-4625 branch September 24, 2024 10:53
panaceya added a commit to mesh-mk-ua/meshtastic-firmware that referenced this pull request Sep 25, 2024
* sed doesn't like newlines (meshtastic#4847)

* sed doesn't like newlines

* fold remove-debug-flags block

* PATH is a system env var

* Runners don't like rm -f ${workspace path}

* chomp trailing newline (meshtastic#4848)

* Fix Ublox M10 Setup (meshtastic#4842)

There is no EXTINT pin available on the Tdeck, which uses
the Ublox M10 GPS. Therefore our previous hack to use that pin
makes the GPS not work. That workaround was implemented to
fix sleep issues which have now since been fixed with the
state machine.

This patch restores the state prior to the hack, which is
known-working.

Additionaly, it was discovered that M10s hate it when you
try and save to non-extistent eeprom/SPI flash.

This patch creates a new SAVE command for the M10 that fixes
this issue.

Many thanks to @MisterC925 whose report and testing was
essential for this fix.

fixes meshtastic#4625

Co-authored-by: Ken McGuire <kenm@paonia.com>

* Remove old comments from main (meshtastic#4849)

These comments were circa 4 years old. Remove them.

* Try v3

* Don't run checks on workflow_dispatch

* Remove native and add v4 back

* Don't wait for after-checks

---------

Co-authored-by: Jason Murray <15822260+scruplelesswizard@users.noreply.github.com>
Co-authored-by: Tom Fifield <tom@tomfifield.net>
Co-authored-by: Ken McGuire <kenm@paonia.com>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
panaceya added a commit to mesh-mk-ua/meshtastic-firmware that referenced this pull request Sep 25, 2024
* sed doesn't like newlines (meshtastic#4847)

* sed doesn't like newlines

* fold remove-debug-flags block

* PATH is a system env var

* Runners don't like rm -f ${workspace path}

* chomp trailing newline (meshtastic#4848)

* Fix Ublox M10 Setup (meshtastic#4842)

There is no EXTINT pin available on the Tdeck, which uses
the Ublox M10 GPS. Therefore our previous hack to use that pin
makes the GPS not work. That workaround was implemented to
fix sleep issues which have now since been fixed with the
state machine.

This patch restores the state prior to the hack, which is
known-working.

Additionaly, it was discovered that M10s hate it when you
try and save to non-extistent eeprom/SPI flash.

This patch creates a new SAVE command for the M10 that fixes
this issue.

Many thanks to @MisterC925 whose report and testing was
essential for this fix.

fixes meshtastic#4625

Co-authored-by: Ken McGuire <kenm@paonia.com>

* Remove old comments from main (meshtastic#4849)

These comments were circa 4 years old. Remove them.

* Try v3

* Don't run checks on workflow_dispatch

* Remove native and add v4 back

* Don't wait for after-checks

* Remove amd64

* Ony run on test runner label

* Got the runner labels backwards

* Setup python

* [create-pull-request] automated change (meshtastic#4858)

Co-authored-by: thebentern <9000580+thebentern@users.noreply.github.com>

* pip3

* pipx

* No args

* Update tests.yml

* Pipargs

* PIO script

* Setup node

* Consolidate commands

* Who chose that ridiculous name anyway?!

* Checkout should handle this but oh well

* Bin path

* Meshtestic submodule update

* master ref

* Actual ref

* python3 ref

* Put this back

* fix meshtastic#4844 (meshtastic#4859)

* Also put this back

---------

Co-authored-by: Jason Murray <15822260+scruplelesswizard@users.noreply.github.com>
Co-authored-by: Tom Fifield <tom@tomfifield.net>
Co-authored-by: Ken McGuire <kenm@paonia.com>
Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: thebentern <9000580+thebentern@users.noreply.github.com>
Co-authored-by: Thomas Göttgens <tgoettgens@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: T-Deck Plus very inconsistent GPS module detection
2 participants