-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get accelerometerThread running from AdminModule. #4886
Get accelerometerThread running from AdminModule. #4886
Conversation
The accelerometerThread fails to start do to new values in `c.payload_variant.device.double_tap_as_button_press` or `c.payload_variant.display.wake_on_tap_or_motion` are not stored in `config.device.double_tap_as_button_press` or `config.display.wake_on_tap_or_motion` before `accelerometerThread->start()` is called, it will compare to old values. AccelerometerThread is also disabled with `disabled()` so it needs to be enabled again before `accelerometerThread->start()`.
you could also call setIntervalFromNow(0) to start it again. disable just sets the next execution to MAX_UINT |
So |
Err, nope - the enabled is still neccessary, but the start is not :-) It was more like a remark´than a change request. |
Don't mind removing it if it's not necessarily. |
I've just tested it without |
The accelerometerThread fails to start do to new values in
c.payload_variant.device.double_tap_as_button_press
orc.payload_variant.display.wake_on_tap_or_motion
are not stored inconfig.device.double_tap_as_button_press
orconfig.display.wake_on_tap_or_motion
beforeaccelerometerThread->start()
is called, it will compare to old values. AccelerometerThread is also disabled withdisabled()
so it needs to be enabled again beforeaccelerometerThread->start()
.Download firmware-2.5.4.fa79bf1.zip. This artifact will be available for 90 days from creation
in `c.payload_variant.device.double_tap_as_button_press` or `c.payload_variant.display.wake_on_tap_or_motion` are not stored in `config.device.double_tap_as_button_press` or `config.display.wake_on_tap_or_motion` before `accelerometerThread->start()` is called, it will compare to old values. AccelerometerThread is also disabled with `disabled()` so it needs to be enabled again before `accelerometerThread->start()`.Download firmware-2.5.4.1a0e7ab.zip. This artifact will be available for 90 days from creation
in `c.payload_variant.device.double_tap_as_button_press` or `c.payload_variant.display.wake_on_tap_or_motion` are not stored in `config.device.double_tap_as_button_press` or `config.display.wake_on_tap_or_motion` before `accelerometerThread->start()` is called, it will compare to old values. AccelerometerThread is also disabled with `disabled()` so it needs to be enabled again before `accelerometerThread->start()`.Download firmware-2.5.4.fa79bf1.zip. This artifact will be available for 90 days from creation
in `c.payload_variant.device.double_tap_as_button_press` or `c.payload_variant.display.wake_on_tap_or_motion` are not stored in `config.device.double_tap_as_button_press` or `config.display.wake_on_tap_or_motion` before `accelerometerThread->start()` is called, it will compare to old values. AccelerometerThread is also disabled with `disabled()` so it needs to be enabled again before `accelerometerThread->start()`.