Remove unused Jlink monitoring files #4953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NRF52 JLINK_MONITOR are unmodified copies of code from Nordic (https://github.com/NordicPlayground/j-link-monitoring-mode-debugging ), which are not used by our firmware and have not been touched in ~4 years.
caveman99
reviewed
Oct 5, 2024
There was a problem hiding this comment.
I am not sure these are needed when enabling segger/jlink debugging for nrf52. @geeksville neds to have a look here for sure.
|
Yeah! I tried to determine that but was unfortunately unable to find where they may link in :) |
thebentern
added a commit
that referenced
this pull request
Oct 5, 2024
This reverts commit 55049ed.
thebentern
added a commit
that referenced
this pull request
Oct 5, 2024
|
Removing this sounds fine. Not currently used. I used it in the very early days. Sorry for late reply not back at computer yet. |
geeksville
approved these changes
Oct 6, 2024
fifieldt
added a commit
that referenced
this pull request
Oct 6, 2024
thebentern
added a commit
that referenced
this pull request
Oct 6, 2024
This reverts commit 55049ed.
thebentern
pushed a commit
that referenced
this pull request
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NRF52 JLINK_MONITOR are unmodified copies of code from Nordic (https://github.com/NordicPlayground/j-link-monitoring-mode-debugging ), which are not used by our firmware and have not been touched in ~4 years.