Rename M5STACK_CORE to prepare for M5STACK_CORE2 and M5STACK_CORES3 #5008
+13
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M5STACK_CORE
2 tasks
caveman99
requested changes
Oct 9, 2024
Rename M5STACK to M5STACK_CORE
lboue
changed the title
caveman99
requested changes
Oct 9, 2024
| #elif defined(M5STACK) | ||
| #define HW_VENDOR meshtastic_HardwareModel_M5STACK | ||
| #elif defined(M5STACK_CORE) | ||
| #define HW_VENDOR meshtastic_HardwareModel_M5STACK_CORE | ||
| #elif defined(STATION_G1) |
There was a problem hiding this comment.
This, on the other hand, needs a change to the protobufs :-) meshtastic_HardwareModel_M5STACK_CORE is not defined there, meshtastic_HardwareModel_M5STACK is. Since it's not used anywhere else, you can leave the old value
There was a problem hiding this comment.
Yes, this is the protobufs PR: meshtastic/protobufs#598
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
M5STACK_COREto prepare for M5STACK_CORE2 and M5STACK_CORES3Depends on meshtastic/protobufs#598.