-
Notifications
You must be signed in to change notification settings - Fork 958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove newline from logging statements. #5022
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tagged a place where we're printing a lot of characters in a loop and putting in a linebreak between the characters will make logs a lot less useful :)
As a separate effort, there are likely a bunch of these log statements that can be disabled for normal use. |
Hmm. For log lines without any variable substitution, could we just use an enum? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed a dozen files in the code that are ones I'm familar with and this looks flawless.
still looking for stuff, WIP