Fix GPS_DEBUG output #5100
Merged
Fix GPS_DEBUG output #5100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the recent change to move logging line breaks to a central location, GPS_DEBUG is now emitting one character per line, making the logs unusable. Patch uses local strings and appends to collate and then print in the right places. Fixes meshtastic#5099
fifieldt
force-pushed
the
fix-gps-linebreaks
branch
from
ca0bb80 to
83958df
Compare
thebentern
approved these changes
Oct 20, 2024
panaceya
added a commit
to mesh-mk-ua/meshtastic-firmware
that referenced
this pull request
Oct 21, 2024
* Add DIO2_AS_RF_SWITCH to pinedio prefilled config. * Add `-p` flag (meshtastic#5093) Add the `-p` to the `mkdir` so it doesn't fail when the folder already exists Co-authored-by: Ben Meadors <benmmeadors@gmail.com> * Revert "Permanently engage !CTRL" * Initial NODENUM_BROADCAST_NO_LORA implementation with NeighborInfo module (meshtastic#5087) * Initial NODENUM_BROADCAST_NO_LORA implementation with NeighborInfo module * isBroadcast * Trunkt * Move 115200 baud GNSS probe earlier (meshtastic#5101) * Move 115200 baud GNSS probe earlier * Even more optimized! * Fix GPS_DEBUG output (meshtastic#5100) After the recent change to move logging line breaks to a central location, GPS_DEBUG is now emitting one character per line, making the logs unusable. Patch uses local strings and appends to collate and then print in the right places. Fixes meshtastic#5099 Co-authored-by: Ben Meadors <benmmeadors@gmail.com> * Wide_Lora uses 12 symbols to be compatible with SX1280 * Fix rebroadcasting encrypted packets when `KNOWN_ONLY` or `LOCAL_ONLY` is used (meshtastic#5109) --------- Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz> Co-authored-by: madeofstown <33820964+madeofstown@users.noreply.github.com> Co-authored-by: Ben Meadors <benmmeadors@gmail.com> Co-authored-by: Thomas Göttgens <tgoettgens@gmail.com> Co-authored-by: Tom Fifield <tom@tomfifield.net> Co-authored-by: GUVWAF <78759985+GUVWAF@users.noreply.github.com>
caveman99
pushed a commit
that referenced
this pull request
Nov 3, 2024
After the recent change to move logging line breaks to a central location, GPS_DEBUG is now emitting one character per line, making the logs unusable. Patch uses local strings and appends to collate and then print in the right places. Fixes #5099 Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the recent change to move logging line breaks to a central location, GPS_DEBUG is now emitting one character per line, making the logs unusable.
Patch uses local strings and appends to collate and then print in the right places.
Fixes #5099