Check if MQTT remote IP is private #5647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 22, 2024
esev
added a commit
to esev/meshtastic-platform-native
that referenced
this pull request
Dec 22, 2024
Update the framework-portduino package to meshtastic/framework-portduino@c36e44f (meshtastic/framework-portduino#42). This is needed for meshtastic/firmware#5647
thebentern
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider a remote MQTT server as private if its host name resolves to a private IP.
Creating this as a draft PR for now, just for providing context to the PRs below. It'll need the following before building for the portduino platforms:Add remote/local IP/Port functions to WiFiClient WiFi#3Update WiFi library to fa7ed2a framework-portduino#42Update platform.json to pickup WiFiClient changes platform-native#7A future update to the commit hash in
platform = https://github.com/meshtastic/platform-native.git#73bd1a21183ca8b00c4ea58bb21315df31a50dff
firmware/arch/portduino/portduino.ini
Line 3 in fa1a1fd