-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task]: 2.6 device-install scripts #6248
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will result in a error : |
Maybe adding a check if filename starts with |
r41d
pushed a commit
to r41d/meshtastic-firmware
that referenced
this pull request
Mar 12, 2025
* update device-install.bat * add device-install unittest * update device-update.bat * update uf2-convert.bat * update regen-protos.bat * update rem * bump version * update device-install.sh * add esptool * move esptool to setup.sh * trunk check+fmt * update uf2-convert.bat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
device-install.bat
anddevice-update.bat
scripts.moving away from some of the double negative filename checks and using batch subrutines. functions
Also allows for a
--debug
flag for testing and visibility..\
, quoted arguments, and so on. Also updated the help section.--tft
and--tft-16mb
flags to be computed during runtime based on filename input.As a bonus that means that the docs doesn't have to be updated to cover those.
device-install.bat
usingdevice-install_test.ps1
This script creates empty
.bin
files and runsdevice-install.bat
allowing for batchscript logic testing and verification.Reworked the Windows
regen-protos.bat
anduf2-convert.bat
scripts in pretty much the same style as above.Simply a standardization effort.
device-install.sh
has been updated with corresponding logic.Same docs bonus there.
trunk check
andtrunk fmt
had a go at the file.esptool.py
has been added to the devcontainer, for local testing.fixes #6186