Add dark mode to application #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajmcquilkin
added
feature request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds dark mode to the application. The application will follow the system theme for application dark mode, but also gives the user the option in the application settings page to override the system theme.
This PR does not explicitly change the map theme, as this is left up to the user in the application settings pane. The theme used in the screenshots below is "Dark Matter" from Carto (https://basemaps.cartocdn.com/gl/dark-matter-gl-style/style.json).
This PR also adds persistence for all application configuration pages, meaning users will no longer need to manually update the same config fields on each application load.
Closes #374
Closes #405
Closes #425