Add status_led_off to support turning status LED off (dark mode) #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Yong <me@ndoo.sg>
ndoo
added a commit
to ndoo/meshtastic-firmware
that referenced
this pull request
Apr 20, 2024
Fixes meshtastic#3635 and depends on [protobufs PR meshtastic#485](meshtastic/protobufs#485) Signed-off-by: Andrew Yong <me@ndoo.sg>
|
Since this is not going to actually enable dark mode what is the point? |
ndoo
added a commit
to ndoo/meshtastic-firmware
that referenced
this pull request
Apr 20, 2024
Fixes meshtastic#3635 and depends on [protobufs PR meshtastic#485](meshtastic/protobufs#485) Signed-off-by: Andrew Yong <me@ndoo.sg>
It does, for the LED that is actually controllable in firmware. The point is that there are users who do not want a blinking LED at night. |
|
I updated the PR text with a slightly more detailed explanation |
thebentern
approved these changes
Apr 20, 2024
ndoo
added a commit
to ndoo/meshtastic-firmware
that referenced
this pull request
Apr 20, 2024
Fixes meshtastic#3635 and depends on [protobufs PR meshtastic#485](meshtastic/protobufs#485) Signed-off-by: Andrew Yong <me@ndoo.sg>
thebentern
added a commit
to meshtastic/firmware
that referenced
this pull request
Apr 22, 2024
* Add ability to turn off status LED blinking Fixes #3635 and depends on [protobufs PR #485](meshtastic/protobufs#485) Signed-off-by: Andrew Yong <me@ndoo.sg> * led_heartbeat_disabled * trunk --------- Signed-off-by: Andrew Yong <me@ndoo.sg> Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add status_led_off to support turning status LED off (dark mode).
This only affects the GPIO-controllable LED and may be desirable behavior for Meshtastic users who sleep in the vicinity of their node and are annoyed by the blinking LED, especially for boards that indicate charging when USB power is connected, resulting in a 1 second LED illumination cycle.
Most boards however, have a non-GPIO controlled power LED (i.e. hardwired to VBUS/VCC/etc.) that can only be turned off by desoldering or otherwise removing that LED. This can't be addressed by firmware changes.
Checklist before merging