Add message protobuf #497
Open
Add message protobuf #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caveman99
requested changes
May 10, 2024
meshtastic/message.proto
Outdated
| /* | ||
| * The sending node's short name. | ||
| */ | ||
| string sender_short_name = 1; |
There was a problem hiding this comment.
Please use the nodenum instead
There was a problem hiding this comment.
This field is used for displaying a device's name on the screen. I don't think it'd be user-friendly to show the device number on the screen rather than the short name.
There was a problem hiding this comment.
i was looking at it from a database point of view, and the short name is not a good way to provide a unique key. Maybe i don'tr fully get how the link to the user entries is made, especially if it is a DM
There was a problem hiding this comment.
No link to the user entry is made given that that's not needed to display the name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Creates needed protobuf changes for firmware PR #3784. It adds a
messageprotobuf which represents a message stored in storage or memory and removes theDeviceStateprotobuf'srx_text_messageas it becomes obsolete.Checklist before merging