-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compass_orientation #515
Conversation
We have rudimentary compass support in a branch. This would add a setting to correct the output when the sensor is oriented differently than the screen.
Should this property specify a unit? Degrees I assume |
I wasn't planning to specify a unit. I can't imagine anything other than 90 degree offsets. So my initial thought is 0 for unchanged, 1 for 90 offset, 2 for 180, 3 for 270, and then 4 would be no offset, but inverted, 5 inverted with a 90 degree offset, etc. But that needs tested on some real world devices, as we might need to describe even more about the arrangement to get the measurement right. |
If that's the case, let's make a uint8 sized enum. Otherwise client developers will be confused what to send |
Yeah, good call. |
We have rudimentary compass support in a branch. This would add a setting to correct the output when the sensor is oriented differently than the screen.