Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added audio_permitted to ChannelSettings #533

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mc-hamster
Copy link
Member

Audio over meshtastic may not be an elegant experience and this will help ensure that audio was intended by the channel originator. Not expecting this to be a hard stop on bad actors, but it's a start.

Added audio_permitted to ChannelSettings.

Audio over meshtastic may not be an elegant experience and this will help ensure that audio was intended by the channel originator. Not expecting this to be a hard stop on bad actors, but it's a start.
@thebentern
Copy link
Contributor

I don't believe there is risk of this happening currently on the tradition band LoRA meshes due to audio module only being available on 2.4GHz LoRA, but it's a good idea to guard against its eventual usage there. I'm wondering if there are other portnums of traffic we might guard against by default though. Perhaps we could have a uint32 as an enum w/ flags enabling those portnums on a channel.

@mc-hamster
Copy link
Member Author

I don't believe there is risk of this happening currently on the tradition band LoRA meshes due to audio module only being available on 2.4GHz LoRA, but it's a good idea to guard against its eventual usage there. I'm wondering if there are other portnums of traffic we might guard against by default though. Perhaps we could have a uint32 as an enum w/ flags enabling those portnums on a channel.

Re: Only available on 2.4ghz - I'm planning on changing that. :)

Great idea idea on the enum!

@thebentern
Copy link
Contributor

thebentern commented Jul 18, 2024

Re: Only available on 2.4ghz - I'm planning on changing that. :)

I'm keen on this idea as well. Especially the idea of a voice memo over the mesh. The T-Deck has full i2s audio that we are just utilizing for ringtones currently. Way under-utilized IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants