Implement more flexible triggering in DetectionSensor #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caveman99
requested changes
Sep 19, 2024
caveman99
approved these changes
Sep 22, 2024
fifieldt
approved these changes
Sep 23, 2024
thebentern
reviewed
Sep 23, 2024
augustozanellato
changed the title
fifieldt
approved these changes
Sep 24, 2024
thebentern
approved these changes
Sep 25, 2024
andrekir
added a commit
to meshtastic/Meshtastic-Android
that referenced
this pull request
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support for meshtastic/firmware#4753, see meshtastic/firmware#4776 for additional context
DetectionSensorConfig.detection_trigger_typesupersedesdetection_triggered_highkeeping same tag because both bools and enums are internally represented as varintsChecklist before merging