Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change modem preset shortcuts to not request channels, and to request remote config when needed #668

Merged

Conversation

ianmcorvidae
Copy link
Contributor

Fixes #662

This should change the --ch-<preset> commands to behave equivalently to --set lora.modem_preset <preset>

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 61.44%. Comparing base (aa6f096) to head (8ba92da).
Report is 41 commits behind head on master.

Files with missing lines Patch % Lines
meshtastic/__main__.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #668      +/-   ##
==========================================
- Coverage   61.48%   61.44%   -0.04%     
==========================================
  Files          24       24              
  Lines        3593     3595       +2     
==========================================
  Hits         2209     2209              
- Misses       1384     1386       +2     
Flag Coverage Δ
unittests 61.44% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ianmcorvidae ianmcorvidae merged commit 584a14f into meshtastic:master Sep 12, 2024
9 of 11 checks passed
@ianmcorvidae ianmcorvidae deleted the channel-preset-optimize branch September 12, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing channel preset over admin channel fails on congested networks
1 participant