Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add other telemetry variants to automatic handling/adding to node information #685

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

ianmcorvidae
Copy link
Contributor

@ianmcorvidae ianmcorvidae commented Oct 12, 2024

This PR makes it so that the other telemetry variants (not just device_metrics) will end up in corresponding spots within interface.nodes and interface.nodesByNum. As is usual here, they'll be camelcased, so parallel to deviceMetrics is environmentMetrics, airQualityMetrics, powerMetrics, and localStats.

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 60.81%. Comparing base (6b9db7a) to head (33fecbd).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
meshtastic/__init__.py 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #685      +/-   ##
==========================================
- Coverage   61.04%   60.81%   -0.23%     
==========================================
  Files          24       24              
  Lines        3748     3762      +14     
==========================================
  Hits         2288     2288              
- Misses       1460     1474      +14     
Flag Coverage Δ
unittests 60.81% <0.00%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ianmcorvidae ianmcorvidae merged commit 6606851 into meshtastic:master Oct 12, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant