Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make several dependencies optional (dotmap, print_color, and pyqrcode) #711

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

ianmcorvidae
Copy link
Contributor

This should assist with packaging, especially in more limited environments such as openwrt and buildroot.

  • dotmap is only used by the meshtastic.test namespace, so now it's imported in a try-catch block
  • logs will only be printed in color if print_color is installed
  • the QR code will only be printed if pyqrcode is installed, but users will be pointed to install it if they want (the QR code options still print the URL itself out)

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 60.22%. Comparing base (89b41c1) to head (4673824).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
meshtastic/__main__.py 68.42% 6 Missing ⚠️
meshtastic/mesh_interface.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
- Coverage   60.29%   60.22%   -0.08%     
==========================================
  Files          24       24              
  Lines        3816     3829      +13     
==========================================
+ Hits         2301     2306       +5     
- Misses       1515     1523       +8     
Flag Coverage Δ
unittests 60.22% <62.50%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ianmcorvidae ianmcorvidae merged commit 7c89e23 into meshtastic:master Dec 13, 2024
11 checks passed
@ianmcorvidae ianmcorvidae deleted the optionalize-deps branch December 13, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant