Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add very simple shell completion using argcomplete #721

Merged
merged 2 commits into from
Dec 22, 2024

Conversation

ianmcorvidae
Copy link
Contributor

Fixes #640 in a rudimentary sort of fashion.

This could probably be improved upon by way of the process shown in the argcomplete docs -- but, it may also be the kind of thing that would depend on local persistence to be very efficient. This does at least add basic completion, which can be enabled with: eval "$(register-python-argcomplete meshtastic)" (which can be put into a bashrc or similar). I'm unclear if argcomplete's support for global completion will work at present.

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.01%. Comparing base (749c6a7) to head (0b15453).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
meshtastic/__main__.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #721      +/-   ##
==========================================
+ Coverage   60.99%   61.01%   +0.02%     
==========================================
  Files          24       24              
  Lines        3899     3907       +8     
==========================================
+ Hits         2378     2384       +6     
- Misses       1521     1523       +2     
Flag Coverage Δ
unittests 61.01% <77.77%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ianmcorvidae ianmcorvidae merged commit 9f286c9 into meshtastic:master Dec 22, 2024
11 checks passed
@ianmcorvidae ianmcorvidae deleted the shell-completion branch December 22, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Shell command completion
1 participant