-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
385 publish b24 php sdk beta 3 #396
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tRepository add contracts account repository for Bitrix24
…-root-folder add security file in root folder
…iconnector 317 add new scope code biconnector
Signed-off-by: mesilov <mesilov.maxim@gmail.com>
fix typehint
Signed-off-by: mesilov <mesilov.maxim@gmail.com>
fix typehint in DealCategoryItemResult
Signed-off-by: mesilov <mesilov.maxim@gmail.com>
rename batch interface
Signed-off-by: mesilov <mesilov.maxim@gmail.com>
fix contracts for apps
Signed-off-by: mesilov <mesilov.maxim@gmail.com>
add service builder factory
Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Signed-off-by: mesilov <mesilov.maxim@gmail.com>
331 add auth node in telephony
Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Signed-off-by: mesilov <mesilov.maxim@gmail.com>
fix undefined index error
Signed-off-by: mesilov <mesilov.maxim@gmail.com>
…ter-result add method isError
Implemented detailed application installation status management in the `ApplicationInstallationInterface` with corresponding methods. Introduced `ApplicationInstallationStatus` enum to define possible states. Included updates to contact person handling and external ID management. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Introduced the ability to set and get the Bitrix24 partner ID for contact persons. Updated tests and documentation to support this new functionality, ensuring comprehensive test coverage and proper documentation. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Extended the ContactPerson entities and their respective tests to include the bitrix24PartnerId/UUid field. This change ensures that we can store and retrieve Bitrix24 partner UUIDs for contact persons, enhancing our data handling capabilities. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Implemented ApplicationInstallationReferenceEntityImplementation for testing ApplicationInstallationInterface. Updated ApplicationInstallationInterface with new methods for managing portal license family and users count. Added tests to validate the new implementation and methods. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Introduce validation logic to check the status before changing application installation status to active or deleted. Also, added extensive unit tests to cover these new behaviors for better reliability and clarity. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Added precondition checks for application status changes. Enhanced documentation for clarity in interface methods with new constraints. Comprehensive tests for `markAsActive`, `markAsBlocked`, and other status-related methods were introduced to ensure correct behavior. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Initialize 'comment' to null, validate 'externalId' input, and introduce ApplicationInstallationRepositoryInterface for persistence operations. Added new exception handling for application installation not found scenarios. Includes in-memory repository implementation and associated tests. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Added a new method `getById` to `ApplicationInstallationRepositoryInterface`. Renamed the test path prefix to `Unit`. Included various new tests for application installations, updating and reorganizing the existing structure. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Introduced the `Bitrix24PartnerStatus` enum to define partner statuses, and a `Bitrix24PartnerInterface` to standardize partner management operations, including partner creation, status changes, and retrieving partner information. This standardization aims to streamline interactions with Bitrix24 partner entities. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Introduce Bitrix24 Partner entity classes and a repository interface with in-memory implementations for testing. Added tests cover save, delete, getById, and associated functions to ensure data persistence operations work correctly. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Locking the phpstan version to 1.11.7 ensures stable and consistent builds. This change avoids potential issues from future updates to the phpstan package. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Replaced Fabric::getLogger with Psr\Log\NullLogger in multiple InMemory repository implementations for consistent logging behavior in unit tests. Adjusted test suite configuration to display warnings. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Updated README for better clarity and readability by adjusting formatting and adding new sections. Improved instructions for running tests and included additional examples for application setup in Bitrix24. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
…ts-and-add-documentation-for-use-cases refactor app contracts and add documentation for use cases
Updated the release date for version 2.0-beta.3 from July 1, 2024, to August 15, 2024. Additionally, noted the migration from `DateTimeImmutable` to `CarbonImmutable` from the Carbon library. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Replace all instances of DateTimeImmutable with CarbonImmutable for improved functionality and better date manipulation capabilities. Adjusted corresponding function calls and tests to align with CarbonImmutable's interface. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Updated CRM models to include new discount-related fields and types. Improved type annotation consistency by switching to CarbonImmutable for date fields. Enhanced integration tests to cover new discount properties and validation. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
This commit introduces new enums for CRM Activity types and directions. Also, it adds a data filter class to handle field exclusion by prefix, and updates integration tests to use these new enums. These changes improve the code maintainability and readability in the CRM module. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Introduced a new trait `CustomBitrix24Assertions` for verifying Bitrix24 API fields against PHPDoc annotations. Incorporated the new assertion in `ContactTest` and adjusted `composer.json` to include necessary dependencies. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Implemented API metadata attributes for service and method documentation. Added GenerateCoverageDocumentationCommand to generate API coverage documentation in Markdown format. This enhances maintainability and provides comprehensive API documentation automatically. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Added `ApiServiceMetadata` and `ApiEndpointMetadata` annotations to relevant classes and methods. Updated methods to handle system and personal notifications, including new functionalities for deleting and marking notifications as read or unread. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
This commit deletes legacy example files and directories that are no longer needed. The removed files include outdated webhook, telephony, and workflow examples that had hardcoded values and were not aligned with the current project architecture. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Deleted outdated local application files including .env, activity-handler.php, and robot-handler.php. Updated README with detailed instructions and examples on working with webhooks and local applications. Added a new composer.json for dependency management in the local-application directory. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Relocated the "Sponsors" section to improve the document's structure. This ensures that sponsorship details are positioned closer to the contributors' section, enhancing logical flow. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Update CHANGELOG.md for new target release date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.x
issue related with 2.x sdk version
improvement
💰 sponsored
задача оплачена
⏳ WIP
work in progress
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.