Release/build2024

.eslintignore

@@ -33,3 +33,4 @@
 **/test/unit/assert.js
 **/test/automation/out/**
 **/typings/**
+!.vscode

.eslintplugin/code-no-dangerous-type-assertions.ts

@@ -0,0 +1,40 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+import * as eslint from 'eslint';
+import { TSESTree } from '@typescript-eslint/experimental-utils';
+
+export = new class NoDangerousTypeAssertions implements eslint.Rule.RuleModule {
+
+	create(context: eslint.Rule.RuleContext): eslint.Rule.RuleListener {
+		// Disable in tests for now
+		if (context.getFilename().includes('.test')) {
+			return {};
+		}
+
+		return {
+			// Disallow type assertions on object literals: <T>{ ... } or {} as T
+			['TSTypeAssertion > ObjectExpression, TSAsExpression > ObjectExpression']: (node: any) => {
+				const objectNode = node as TSESTree.Node;
+
+				const parent = objectNode.parent as TSESTree.TSTypeAssertion | TSESTree.TSAsExpression;
+				if (
+					// Allow `as const` assertions
+					(parent.typeAnnotation.type === 'TSTypeReference' && parent.typeAnnotation.typeName.type === 'Identifier' && parent.typeAnnotation.typeName.name === 'const')
+
+					// For also now still allow `any` casts
+					|| (parent.typeAnnotation.type === 'TSAnyKeyword')
+				) {
+					return;
+				}
+
+				context.report({
+					node,
+					message: "Don't use type assertions for creating objects as this can hide type errors."
+				});
+			},
+		};
+	}
+};

.eslintplugin/code-no-potentially-unsafe-disposables.ts

@@ -0,0 +1,37 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+import * as eslint from 'eslint';
+
+/**
+ * Checks for potentially unsafe usage of `DisposableStore` / `MutableDisposable`.
+ *
+ * These have been the source of leaks in the past.
+ */
+export = new class implements eslint.Rule.RuleModule {
+
+	create(context: eslint.Rule.RuleContext): eslint.Rule.RuleListener {
+		function checkVariableDeclaration(inNode: any) {
+			context.report({
+				node: inNode,
+				message: `Use const for 'DisposableStore' to avoid leaks by accidental reassignment.`
+			});
+		}
+
+		function checkProperty(inNode: any) {
+			context.report({
+				node: inNode,
+				message: `Use readonly for DisposableStore/MutableDisposable to avoid leaks through accidental reassignment.`
+			});
+		}
+
+		return {
+			'VariableDeclaration[kind!="const"] NewExpression[callee.name="DisposableStore"]': checkVariableDeclaration,
+
+			'PropertyDefinition[readonly!=true][typeAnnotation.typeAnnotation.typeName.name=/DisposableStore|MutableDisposable/]': checkProperty,
+			'PropertyDefinition[readonly!=true] NewExpression[callee.name=/DisposableStore|MutableDisposable/]': checkProperty,
+		};
+	}
+};

.eslintplugin/code-parameter-properties-must-have-explicit-accessibility.ts

@@ -0,0 +1,41 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+import * as eslint from 'eslint';
+import { TSESTree } from '@typescript-eslint/experimental-utils';
+
+/**
+ * Enforces that all parameter properties have an explicit access modifier (public, protected, private).
+ *
+ * This catches a common bug where a service is accidentally made public by simply writing: `readonly prop: Foo`
+ */
+export = new class implements eslint.Rule.RuleModule {
+
+	create(context: eslint.Rule.RuleContext): eslint.Rule.RuleListener {
+		function check(inNode: any) {
+			const node: TSESTree.TSParameterProperty = inNode;
+
+			// For now, only apply to injected services
+			const firstDecorator = node.decorators?.at(0);
+			if (
+				firstDecorator?.expression.type !== 'Identifier'
+				|| !firstDecorator.expression.name.endsWith('Service')
+			) {
+				return;
+			}
+
+			if (!node.accessibility) {
+				context.report({
+					node: inNode,
+					message: 'Parameter properties must have an explicit access modifier.'
+				});
+			}
+		}
+
+		return {
+			['TSParameterProperty']: check,
+		};
+	}
+};

.eslintrc.json

@@ -70,7 +70,10 @@
 		],
 		"local/code-translation-remind": "warn",
 		"local/code-no-native-private": "warn",
+		"local/code-parameter-properties-must-have-explicit-accessibility": "warn",
 		"local/code-no-nls-in-standalone-editor": "warn",
+		"local/code-no-potentially-unsafe-disposables": "warn",
+		"local/code-no-dangerous-type-assertions": "off",
 		"local/code-no-standalone-editor": "warn",
 		"local/code-no-unexternalized-strings": "warn",
 		"local/code-must-use-super-dispose": "warn",
@@ -154,14 +157,11 @@
 							"src/vs/editor/contrib/codeAction/test/browser/codeActionModel.test.ts",
 							"src/vs/editor/test/common/services/languageService.test.ts",
 							"src/vs/editor/test/node/classification/typescript.test.ts",
-							"src/vs/editor/test/node/diffing/defaultLinesDiffComputer.test.ts",
-							"src/vs/editor/test/node/diffing/fixtures.test.ts",
 							"src/vs/platform/configuration/test/common/configuration.test.ts",
 							"src/vs/platform/extensions/test/common/extensionValidator.test.ts",
 							"src/vs/platform/opener/test/common/opener.test.ts",
 							"src/vs/platform/registry/test/common/platform.test.ts",
 							"src/vs/platform/remote/test/common/remoteHosts.test.ts",
-							"src/vs/platform/telemetry/test/browser/1dsAppender.test.ts",
 							"src/vs/platform/workspace/test/common/workspace.test.ts",
 							"src/vs/platform/workspaces/test/electron-main/workspaces.test.ts",
 							"src/vs/workbench/api/test/browser/mainThreadConfiguration.test.ts",
@@ -672,7 +672,6 @@
 							"vscode-regexpp",
 							"vscode-textmate",
 							"worker_threads",
-							"@xterm/addon-canvas",
 							"@xterm/addon-image",
 							"@xterm/addon-search",
 							"@xterm/addon-serialize",
@@ -859,7 +858,11 @@
 							}, // TODO@layers
 							"tas-client-umd", // node module allowed even in /common/
 							"vscode-textmate", // node module allowed even in /common/
-							"@vscode/vscode-languagedetection" // node module allowed even in /common/
+							"@vscode/vscode-languagedetection", // node module allowed even in /common/
+							{
+								"when": "hasBrowser",
+								"pattern": "@xterm/xterm"
+							} // node module allowed even in /browser/
 						]
 					},
 					{

.github/CODEOWNERS

@@ -0,0 +1,3 @@
+# ensure the API police is aware of changes to the vscode-dts file
+# this is only about the final API, not about proposed API changes
+src/vscode-dts/vscode.d.ts @jrieken @mjbvz

.github/commands.json

@@ -156,37 +156,6 @@
 		"addLabel": "confirmation-pending",
 		"removeLabel": "confirmed"
 	},
-	{
-		"type": "comment",
-		"name": "needsMoreInfo",
-		"allowUsers": [
-			"cleidigh",
-			"usernamehw",
-			"gjsjohnmurray",
-			"IllusionMH"
-		],
-		"action": "updateLabels",
-		"addLabel": "~info-needed"
-	},
-	{
-		"type": "comment",
-		"name": "needsPerfInfo",
-		"allowUsers": [
-			"cleidigh",
-			"usernamehw",
-			"gjsjohnmurray",
-			"IllusionMH"
-		],
-		"addLabel": "info-needed",
-		"comment": "Thanks for creating this issue regarding performance! Please follow this guide to help us diagnose performance issues: https://github.com/microsoft/vscode/wiki/Performance-Issues \n\nHappy Coding!"
-	},
-	{
-		"type": "comment",
-		"name": "jsDebugLogs",
-		"action": "updateLabels",
-		"addLabel": "info-needed",
-		"comment": "Please collect trace logs using the following instructions:\n\n> If you're able to, add `\"trace\": true` to your `launch.json` and reproduce the issue. The location of the log file on your disk will be written to the Debug Console. Share that with us.\n>\n> ⚠️ This log file will not contain source code, but will contain file paths. You can drop it into https://microsoft.github.io/vscode-pwa-analyzer/index.html to see what it contains. If you'd rather not share the log publicly, you can email it to connor@xbox.com"
-	},
 	{
 		"type": "comment",
 		"name": "closedWith",
@@ -200,30 +169,6 @@
 		"reason": "completed",
 		"addLabel": "unreleased"
 	},
-	{
-		"type": "label",
-		"name": "~info-needed",
-		"action": "updateLabels",
-		"addLabel": "info-needed",
-		"removeLabel": "~info-needed",
-		"comment": "Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our [issue reporting guidelines](https://aka.ms/vscodeissuereporting). Please take the time to review these and update the issue.\n\nHappy Coding!"
-	},
-	{
-		"type": "label",
-		"name": "~version-info-needed",
-		"action": "updateLabels",
-		"addLabel": "info-needed",
-		"removeLabel": "~version-info-needed",
-		"comment": "Thanks for creating this issue! We figured it's missing some basic information, such as a version number, or in some other way doesn't follow our [issue reporting guidelines](https://aka.ms/vscodeissuereporting). Please take the time to review these and update the issue.\n\nHappy Coding!"
-	},
-	{
-		"type": "label",
-		"name": "~confirmation-needed",
-		"action": "updateLabels",
-		"addLabel": "info-needed",
-		"removeLabel": "~confirmation-needed",
-		"comment": "Please diagnose the root cause of the issue by running the command `F1 > Help: Troubleshoot Issue` and following the instructions. Once you have done that, please update the issue with the results.\n\nHappy Coding!"
-	},
 	{
 		"type": "comment",
 		"name": "a11ymas",
@@ -469,32 +414,6 @@
 		"addLabel": "*caused-by-extension",
 		"comment": "It looks like this is caused by the Copilot extension. Please file the issue in the [Copilot Discussion Forum](https://github.com/community/community/discussions/categories/copilot). Make sure to check their issue reporting template and provide them relevant information such as the extension version you're using. See also our [issue reporting guidelines](https://aka.ms/vscodeissuereporting) for more information.\n\nHappy Coding!"
 	},
-	{
-		"type": "comment",
-		"name": "gifPlease",
-		"allowUsers": [
-			"cleidigh",
-			"usernamehw",
-			"gjsjohnmurray",
-			"IllusionMH"
-		],
-		"action": "comment",
-		"addLabel": "info-needed",
-		"comment": "Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, `.gif` files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.\n\nIf the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (`Developer: Toggle Screencast Mode` in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.\n\nHappy coding!"
-	},
-	{
-		"type": "comment",
-		"name": "confirmPlease",
-		"allowUsers": [
-			"cleidigh",
-			"usernamehw",
-			"gjsjohnmurray",
-			"IllusionMH"
-		],
-		"action": "comment",
-		"addLabel": "info-needed",
-		"comment": "Please diagnose the root cause of the issue by running the command `F1 > Help: Troubleshoot Issue` and following the instructions. Once you have done that, please update the issue with the results.\n\nHappy Coding!"
-	},
 	{
 		"__comment__": "Allows folks on the team to label issues by commenting: `\\label My-Label` ",
 		"type": "comment",

.github/workflows/deep-classifier-runner.yml

@@ -1,4 +1,9 @@
 name: "Deep Classifier: Runner"
+
+permissions:
+  id-token: write
+  contents: read
+
 on:
   schedule:
     - cron: 0 * * * *
@@ -9,7 +14,13 @@ on:
 jobs:
   main:
     runs-on: ubuntu-latest
+    environment: main
     steps:
+      - uses: azure/login@v2
+        with:
+            client-id: ${{ vars.AZURE_CLIENT_ID }}
+            tenant-id: ${{ vars.AZURE_TENANT_ID }}
+            allow-no-subscriptions: true
       - name: Checkout Actions
         uses: actions/checkout@v4
         with:
@@ -47,8 +58,4 @@ jobs:
         with:
           configPath: classifier
           allowLabels: "info-needed|new release|error-telemetry|*english-please|translation-required"
-          tenantId: ${{secrets.TOOLS_TENANT_ID}}
-          clientId: ${{secrets.TOOLS_CLIENT_ID}}
-          clientSecret: ${{secrets.TOOLS_CLIENT_SECRET}}
-          clientScope: ${{secrets.TOOLS_CLIENT_SCOPE}}
           token: ${{secrets.VSCODE_ISSUE_TRIAGE_BOT_PAT}}

.gitignore

@@ -4,6 +4,7 @@ npm-debug.log
 Thumbs.db
 node_modules/
 .build/
+.vscode/extensions/**/out/
 extensions/**/dist/
 /out*/
 /extensions/**/out/

.nvmrc

@@ -1 +1 @@
-18.17.1
+20.12.1

.vscode/extensions.json

@@ -6,7 +6,6 @@
 		"editorconfig.editorconfig",
 		"github.vscode-pull-request-github",
 		"ms-vscode.vscode-github-issue-notebooks",
-		"ms-vscode.vscode-selfhost-test-provider",
 		"ms-vscode.extension-test-runner",
 		"jrieken.vscode-pr-pinger"
 	]

.vscode/extensions/vscode-selfhost-test-provider/.vscode/launch.json

@@ -0,0 +1,11 @@
+{
+	"configurations": [
+		{
+			"args": ["--extensionDevelopmentPath=${workspaceFolder}", "--enable-proposed-api=ms-vscode.vscode-selfhost-test-provider"],
+			"name": "Launch Extension",
+			"outFiles": ["${workspaceFolder}/out/**/*.js"],
+			"request": "launch",
+			"type": "extensionHost"
+		}
+	]
+}

.vscode/extensions/vscode-selfhost-test-provider/.vscode/settings.json

@@ -0,0 +1,7 @@
+{
+	"editor.formatOnSave": true,
+	"editor.defaultFormatter": "vscode.typescript-language-features",
+	"editor.codeActionsOnSave": {
+		"source.organizeImports": "always"
+	}
+}