-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: bump minimum required pyproject-metadata version to 0.8.0 #613
Conversation
3f99f81
to
90dc785
Compare
d1da1af
to
e97a3fe
Compare
This is ready to merge when we are ready to bump the minimum required pyproject-metadata version. |
I think it's okay to bump to a fairly recent version. PDM and scikit-build-core now both vendor It may be useful to check |
It's been 6 months, so I think this can be merged now after a small update to resolve the merge conflict, and possibly add the below check:
|
I think it could be useful to cut a release (let's call it 0.16.1 or 0.17.0) before merging this. There are a couple of bug fixes on main that it would be nice to get out with minimal effort from distributors. I can prepare the release. I'm not convinced that we should start verifying the version of all dependencies, just because someone may have done a poor job in packaging. We haven't checked that pyproject-metadata is version 0.7.1 or later so far, thus adding a check for version 0.8.0 or later should not be necessary either. We check for ninja and meson versions because these are not Python libraries and we had evidence of the wrong ones being picked up because of |
Good point, +1 for doing a release first. Okay, fair enough re version check - we can always add it later in case bug reports show a real-world need. |
I've prepared the release, see #687 |
e97a3fe
to
9b7425b
Compare
Update tests to consider only pyproject-metadata 0.8.0 behavior.
9b7425b
to
9608ba0
Compare
No description provided.