Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meson format: --recursive causes backtrace when root is unset #13568

Closed
dcbaker opened this issue Aug 19, 2024 · 0 comments · Fixed by #13571
Closed

meson format: --recursive causes backtrace when root is unset #13568

dcbaker opened this issue Aug 19, 2024 · 0 comments · Fixed by #13571
Labels
bug tool:format

Comments

@dcbaker
Copy link
Member

dcbaker commented Aug 19, 2024

Describe the bug
running meson format -r with no root key in the meson.format file causes an unhandled python exception

To Reproduce
create a meson.format file without a root key

Expected behavior
A nicer error message, and not uncaught python exception. It would also be nice if this could be read from the .editorconfig file if that's present.

system parameters
meson 1.5 and master (cdf646f)
dcbaker added a commit to dcbaker/meson that referenced this issue Aug 19, 2024
@dcbaker
mformat: correctly handle editorconfig files without the root setting
7ac5ee9 
Which happens when a .editorconfig is in a subdirectory, not the root.
In this case we need Set the fallback value to `False`, which is what
editorconfig expects.

Closes: mesonbuild#13568
dcbaker added a commit to dcbaker/meson that referenced this issue Aug 19, 2024
@dcbaker
mformat: correctly handle editorconfig files without the root setting
d3e284d 
Which happens when a .editorconfig is in a subdirectory, not the root.
In this case we need Set the fallback value to `False`, which is what
editorconfig expects.

Closes: mesonbuild#13568
@dcbaker dcbaker mentioned this issue Aug 19, 2024
Merged
eli-schwartz pushed a commit that referenced this issue Sep 16, 2024
@dcbaker @eli-schwartz
mformat: correctly handle editorconfig files without the root setting
7e97381 
Which happens when a .editorconfig is in a subdirectory, not the root.
In this case we need Set the fallback value to `False`, which is what
editorconfig expects.

Closes: #13568
(cherry picked from commit 18f4a05)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug tool:format
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mformat: correctly handle editorconfig files without the root setting dcbaker/meson
1 participant
@dcbaker