Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid keyword arguments should raise an error #3

Closed
RobinMcCorkell opened this issue Aug 12, 2014 · 2 comments
Closed

Invalid keyword arguments should raise an error #3

RobinMcCorkell opened this issue Aug 12, 2014 · 2 comments

Comments

@RobinMcCorkell
Copy link
Contributor

Keyword arguments unsupported by the respective function should raise an error during parsing, not be silently ignored. A case where this would have made a big difference is the change from include_dirs to include_directories - existing code would fail during building after the Meson upgrade with no clear indication why.

@jpakkane
Copy link
Member

Yes. This is fixed now.

I did the include_dirs change like this because, truth be told, I did not know of anyone using Meson for production yet. If I had known that I would have made the change so that they both are valid for a while with a deprecation warning if you use the old one.

@RobinMcCorkell
Copy link
Contributor Author

While Meson is in alpha/beta, it is perfectly fine to make incompatible changes. I wouldn't say I'm exactly 'production', but I've started having a look at Meson as a next-gen build system, and I like what I see so far and want to help make it better 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants