fix regression in precomputing CMAKE_SIZEOF_VOID_P #11761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scrumplex
approved these changes
May 2, 2023
There was a problem hiding this comment.
This fixes the build issue with https://github.com/marzer/tomlplusplus.
|
Thanks for working on this, please move the |
MaxHearnden
force-pushed
the
CMAKE_SIZEOF_VOID_P
branch
from
16a7540 to
2c7dbcf
Compare
|
done |
12 tasks
eli-schwartz
added
compilers
module:cmake
|
A better commit message might be something like: |
In commit 808d593, compiler.sizeof was refactored to introduce caching, but cmake subprojects did not adapt to that API change and ended up embedding the python repr of a tuple as a cmake variable.
MaxHearnden
force-pushed
the
CMAKE_SIZEOF_VOID_P
branch
from
2c7dbcf to
e12b5c1
Compare
MaxHearnden
changed the title
MaxHearnden
added a commit
to MaxHearnden/nixpkgs
that referenced
this pull request
May 2, 2023
eli-schwartz
added a commit
to eli-schwartz/meson
that referenced
this pull request
May 3, 2023
In mesonbuild#11761 it turned out that we failed to correctly handle all compiler.sizeof API changes in an old commit, breaking use of the module. And mypy could have caught this for us, except that the module is neither typed nor checked in CI. Partially solve this by adding lots of type annotations, greatly reducing the number of mypy errors in this file from 35 down to 12.
fabaff
pushed a commit
to fabaff/nixpkgs
that referenced
this pull request
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes NixOS/nixpkgs#229358
restores the pre caching behavior (808d593)