Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LTO-related testcases on Cygwin #13506

Merged
merged 3 commits into from
Aug 4, 2024
Merged

Fix LTO-related testcases on Cygwin #13506

merged 3 commits into from
Aug 4, 2024

Conversation

jon-turney
Copy link
Member

Fixes #13465

make is used internally by gcc (for scheduling multithreaded lto) when the '-flto' flag is used.

@jon-turney jon-turney requested a review from jpakkane as a code owner August 3, 2024 13:37
@jon-turney
Copy link
Member Author

jon-turney commented Aug 3, 2024 •
edited
Loading

Future work: it might make sense for detect_tools() to report make's presence into the test log (since we have a test which explicitly uses it), but this isn't quite straightforward, as there isn't an unambiguous version number to be associated with make when it might not be GNU make .

@jon-turney
CI: Install make on Cygwin
97fc2a1 
Test '230 external project' uses make, but is too dumb to use the
platform conventions for shared library names in installed files
expected by shared_lib, so special case that.
@jon-turney
Revert "CI: skip LTO tests on cygwin"
2f49804 
This reverts commit 0c93149.
@jpakkane jpakkane merged commit b875c75 into mesonbuild:master Aug 4, 2024
35 checks passed
@jpakkane
Copy link
Member

jpakkane commented Aug 4, 2024

Thanks.

@jon-turney jon-turney deleted the cygwin-lto-fix branch August 4, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpakkane jpakkane Awaiting requested review from jpakkane jpakkane is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cygwin CI failure with LTO?
2 participants
@jon-turney @jpakkane