linkers: skip -export_dynamic flag before MacOS 10.7 #13557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flag was only introduced in ld 224.1, as mentioned in the initial PR mesonbuild#13291. Resolves mesonbuild#13543
wolfgangwalther
force-pushed
the
skip-export-dynamic-before-10-7
branch
from
fdd34b6 to
e58a8cc
Compare
This was referenced Aug 17, 2024
|
@wolfgangwalther Thank you, I will try this soon. |
|
@wolfgangwalther Looks like it works as intended. I have replaced our patch which simply reverts adding the flag with your patch, and can still build @ryandesign Ryan, could you verify on an Intel machine just in case? |
dcbaker
approved these changes
Aug 19, 2024
It only fixes a regression for MacOS before 10.7, so should be good. Just wanted to confirm with the test, that I got the two versions involved (MacOS system + linker) right. But that seems to be the case. |
dcbaker
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13543.
@barracuda156 @ryandesign can anyone test this on MacOS 10.6.x and MacOS 10.7 to confirm? I only have a much more recent version available.
CC @tristan957