compilers: Pass all options to links/compiles #13687
Draft
+32
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fairly sure that #13610 is an oversight in meson that should be fixed but I'm not at all sure that the approach that I have taken to fix it in this PR is the right one. With that in mind, your feedback is invaluable. |
The `compiler.links()` and `compiler.compiles()` functions did not take into account all arguments which might be added to a real link or real compile job, specifically it was failing to add many of the options which are added as a result of language level options such as `b_coverage` or `b_sanitize`. This commit fixes that by constructing the args list for these functions using the same methods as a real compile/link job. A new unittest has been added to check that this is functioning correctly. Fixes: mesonbuild#13610
amcn
force-pushed
the
amcn/compiler_funcs_get_all_args
branch
from
819f063
to
1fab41c
Compare
|
As test failures can attest, this needs more time to cook. Converting to draft until it's ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
compiler.links()andcompiler.compiles()functions did not take into account all arguments which might be added to a real link or real compile job, specifically it was failing to add many of the options which are added as a result of language level options such asb_coverageorb_sanitize.This commit fixes that by constructing the args list for these functions using the same methods as a real compile/link job.
A new unittest has been added to check that this is functioning correctly.
Fixes: #13610