Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS: Add support for /utf-8 #13929

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

VS: Add support for /utf-8 #13929

wants to merge 7 commits into from
+158 −59

Commits on Nov 22, 2024

  1. vs: Set remaining build options via <AdditionalOptions> 

    Some arguments correspond to MSBuild properties ($(VCTargetsPath)\Microsoft.cpp*.props),
for example:

 * /EH: <ExceptionHandling>
 * /O: <Optimization>
 * etc.

The ones which have no corresponding property must be specified via <AdditionalOptions>.
    @lb90
    lb90 committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    6e1f031 View commit details
    Browse the repository at this point in the history

  2. vs: Honour the compiler and linker's always_args

    @lb90
    lb90 committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    b9f4117 View commit details
    Browse the repository at this point in the history

  3. MSVCCompiler: return copy of always_args list to caller 

    Otherwise it's going to be modified (e.g in the vs generator)
    @lb90
    lb90 committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    43fbba4 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2024

  1. WIP

    @lb90
    lb90 committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    e6a92b8 View commit details
    Browse the repository at this point in the history

  2. MSVCCompiler: Drop /utf-8 from always args 

    We're going to add /utf-8 back in subsequent commit
    @lb90
    lb90 committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    5efa8a9 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Add Compiler.add_default_build_args(CompileArgs) method 

    Thisi can be used to add default args. Unlike always args, default
args can be overriden.
    @lb90
    lb90 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    23c4d56 View commit details
    Browse the repository at this point in the history

  2. VisualStudioLikeCompiler: Implement add_default_build_args() to set /… 

    …utf-8
    @lb90
    lb90 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    5374e76 View commit details
    Browse the repository at this point in the history