Prototype support for PEP 739 #13945
Conversation
FFY00
force-pushed
the
pep-739-prototype
branch
from
ea9aed7 to
697e20c
Compare
|
Rebased on |
FFY00
force-pushed
the
pep-739-prototype
branch
2 times, most recently
from
64f9781 to
e9deda3
Compare
Thanks! I have requested a review for the PEP, so hopefully we should hear something soon. If it gets accepted, I'll add the file to CPython as soon as possible, so it should be available on the following release. I'll also publish a package to generate the build config file to PyPI, so that we can use it on older Python versions, or Python implementations that do not ship it, as long as you are able to run code on the target. Afterwards, in a followup to PEP 739, I also want to standardize a file for the installation environment, which will provide the installation paths. We'll ship a file for the default environment, and unless we run into some issue, I'll also get |
FFY00
force-pushed
the
pep-739-prototype
branch
5 times, most recently
from
43fcae5 to
f30406d
Compare
|
The PEP has been accepted. https://peps.python.org/pep-0739/ I'll add support for it in Python 3.14, and then come back to this PR. |
mesonbuild/dependencies/pkgconfig.py
Outdated
| extra_paths: T.List[str] = self.env.coredata.optstore.get_value(key)[:] | ||
| extra_paths: T.List[str] = self.env.coredata.optstore.get_value(key)[:] + self.extra_paths |
There was a problem hiding this comment.
Hmm, I see what you're doing here. You allow a PkgConfigDependency to take an additional PKG_CONFIG_PATH which is joined to the one in the cross file, which also means we don't need to push/pop os.environ.
On the flip side, the way we previously used it was via PKG_CONFIG_LIBDIR which was more narrowly scoped. I suspect this change means we can accidentally fall back to a different python than the one we were searching for (but still the same major.minor version at least)...
There was a problem hiding this comment.
Ah hold on, we anyways fall back to checking for pkg-config without the internal LIBPC which means this is actually doing exactly what we want with one less check. Heh. :)
There was a problem hiding this comment.
Yeah, and without modifying os.environ 😊
Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
FFY00
force-pushed
the
pep-739-prototype
branch
4 times, most recently
from
bc6ef41 to
b5e8baa
Compare
…figDependency Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
The overall goal is to support targeting Python installations without need for introspection, given all necessary information is given externally.
This is built upon:
_sysconfigdatato a JSON file python/cpython#127178, forpy_installation.get_variable/py_installation.has_variablesupportThis PR is just a prototype, as I work to get all necessary pieces finalized.