c: add more exceptions to -Wno-* #14841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit eca1ac1 (mesonbuild#14252) added support for properly detecting the -Wno-vla-larger-than flag: a value must be specified for its positive form (-Wvla-larger-than=N), or GCC will exit with the error "missing argument to ‘-Walloc-size-larger-than=’". There is a handful of other -Wno-* flags whose positive form act in the same manner, but are not covered here: * -Wno-alloc-size-larger-than (GCC >=7.1.0) * -Wno-alloca-larger-than (GCC >=7.1.0) * -Wno-frame-larger-than (GCC >=4.4.0) * -Wno-stack-usage (GCC >=4.7.0) Add logic to treat these in the same way. Signed-off-by: Henrik Lehtonen <eigengrau@vm86.se>
helehto
force-pushed
the
more-wno-handling
branch
from
b489278 to
f3cf0e4
Compare
Comment on lines
+1280
to
+1286
| elif arg in { | ||
| '-Wno-alloc-size-larger-than', | ||
| '-Wno-alloca-larger-than', | ||
| '-Wno-frame-larger-than', | ||
| '-Wno-stack-usage', | ||
| '-Wno-vla-larger-than', | ||
| }: |
Member
There was a problem hiding this comment.
Suggested change
| elif arg in { | |
| '-Wno-alloc-size-larger-than', | |
| '-Wno-alloca-larger-than', | |
| '-Wno-frame-larger-than', | |
| '-Wno-stack-usage', | |
| '-Wno-vla-larger-than', | |
| }: | |
| elif arg in {'-Wno-alloc-size-larger-than', | |
| '-Wno-alloca-larger-than', | |
| '-Wno-frame-larger-than', | |
| '-Wno-stack-usage', | |
| '-Wno-vla-larger-than'}: |
Just a small nit. It's difficult to read code when the condition for the if is dedented back, and the conditional lines up with and blends into the body.
The dedent style is unfortunately popularized somewhat by "black" (whose stated goal is not "readable code") but is best avoided.
Fixed via 8c9bf41.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit eca1ac1 (#14252) added support for properly detecting the -Wno-vla-larger-than flag: a value must be specified for its positive form (-Wvla-larger-than=N), or GCC will exit with the error "missing argument to ‘-Walloc-size-larger-than=’".
There is a handful of other -Wno-* flags whose positive form act in the same manner, but are not covered here:
Add logic to treat these in the same way.