Use base_prefix, not prefix for iOS framework linking. #14849
Conversation
|
Sorry to be a squeaky wheel here, but is there anything I can do to get some eyeballs on this change? |
|
Thank you very much for pinging on this! For some reason I simply do not recall having noticed this PR. It looks very reasonable though. One thing I'd probably suggest doing is including important rationales that are present in the PR description, inside the commit message itself. This is helpful when using |
Understood - do you want me to re-push the commit with those descriptions, or is this "for next time" advice? |
|
Can you re-push? |
Outside of a venv, sys.prefix and sys.base_prefix are the same. However, if you're using a virtual environment, sys.prefix points at the location of the virtual environment, not the location of the iOS binaries. sys.base_prefix should be used to ensure that you're always referencing the underlying install location, not the venv location.
freakboy3742
force-pushed
the
ios-base-prefix
branch
from
979aac1 to
9f836ba
Compare
|
@eli-schwartz Done - including rebasing against the current master. |
3 participants
Modifies iOS linking with the Python framework to use
sys.base_prefix, rather thansys.prefix.Outside of a venv,
sys.prefixandsys.base_prefixare the same. However, if you're using a virtual environment.sys.prefixpoints at the location of the virtual environment, not the location of the iOS binaries.sys.base_prefixshould be used to ensure that you're always referencing the underlying install location, not the venv location.