vala: Remove space from --target-glib version #15173
Conversation
If the dependency version contains a space:
dependency('glib-2.0', version: '>= 2.40.0')
Then the --target-glib version has a space:
--target-glib ' 2.40.0'
| for req in dep.version_reqs: | ||
| if req.startswith(('>=', '==')): | ||
| commands += ['--target-glib', req[2:]] | ||
| commands += ['--target-glib', req[2:].strip()] |
There was a problem hiding this comment.
This would make it easy for people to write meson.build files that only work with the latest version of meson, by accident, because they don't realize that they are passing badly formatted values to vala?
The general solution for this is to use a FeatureNew if you detect that this condition was relevant at runtime, for example if stripping produces a different string value.
There was a problem hiding this comment.
There's not one nice simple example, but it seems to be just a cosmetic fix. Using meson's test cases/vala/14 target glib version and gresources
valac-0.56 test.vala --pkg gtk+-3.0 --gresources gres/test-resources.xml --target-glib <x>
warnings when:
x=2.40
x = ' 2.40'
no warnings when:
x=auto
x=2.70
x=' 2.70'
fails with
error: Only a stable version of GLib can be targeted, use MAJOR.MINOR format with MINOR as an even number
error: This version of valac only supports GLib 2
when x=' xxxx'
2 participants
If the dependency version contains a space:
dependency('glib-2.0', version: '>= 2.40.0')
Then the --target-glib version has a space:
--target-glib ' 2.40.0'